pgpool2.git / summary / log / commit / refs
commit ef21742c2dcf7230aaae5daf6edabfff7cec6148
Author: Muhammad Usama <m.usama@gmail.com>
Date: Tue Jan 26 14:43:22 2016 +0000
Removing a debug message that could leak auth key in IPC JSON data
The problem was identified by Yugo.
src/watchdog/watchdog.c | 6 +-----
src/watchdog/wd_commands.c | 2 +-
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/src/watchdog/watchdog.c b/src/watchdog/watchdog.c
index 86796f7bd..87753fb32 100644
--- a/src/watchdog/watchdog.c
+++ b/src/watchdog/watchdog.c
@@ -4887,15 +4887,11 @@ static bool process_pgpool_replicate_command(WatchdogNode* wdNode, WDPacketData*
if (pkt->data == NULL || pkt->len == 0)
{
ereport(LOG,
- (errmsg("watchdog is unable to process pgpool replicate command"),
+ (errmsg("watchdog is unable to process pgpool replicate command"),
errdetail("command packet contains no data")));
return false;
}
- ereport(DEBUG1,
- (errmsg("processing pgpool replicate variable command"),
- errdetail("%s",pkt->data)));
-
if (parse_wd_node_function_json(pkt->data, pkt->len, &func_name, &node_id_list, &node_count))
ret = process_wd_command_function(wdNode, pkt, func_name, node_count, node_id_list);
else
diff --git a/src/watchdog/wd_commands.c b/src/watchdog/wd_commands.c
index e5ecf2ac3..ab1e29745 100644
--- a/src/watchdog/wd_commands.c
+++ b/src/watchdog/wd_commands.c
@@ -222,7 +222,7 @@ issue_command_to_watchdog(char type, int timeout_sec, char* data, int data_len,
pfree(result->data);
pfree(result);
ereport(DEBUG1,
- (errmsg("error reading from IPC command socket"),
+ (errmsg("error reading from IPC command socket"),
errdetail("read from socket failed with error \"%s\"",strerror(errno))));
close(sock);
return NULL;
[parent: c2c6afbf4530]