postgres.git / summary / log / commit / refs

commit    ef2a83323c3b5ecbdcd113a61c4eddf968d29508
Author:   Alvaro Herrera <alvherre@alvh.no-ip.org>
Date:     Thu Jan 28 15:50:40 2021 +0000
First released in: 14.0, 9.5.25, 9.6.21, 10.16, 11.11, 12.6, 13.2

    pgbench: Remove dead code
    
    doConnect() never returns connections in state CONNECTION_BAD, so
    checking for that is pointless.  Remove the code that does.
    
    This code has been dead since ba708ea3dc84, 20 years ago.
    
    Discussion: https://postgr.es/m/20210126195224.GA20361@alvherre.pgsql
    Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>


 src/bin/pgbench/pgbench.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
index 84e3aa9ece5..9b3c17d1d9b 100644
--- a/src/bin/pgbench/pgbench.c
+++ b/src/bin/pgbench/pgbench.c
@@ -6044,13 +6044,6 @@ main(int argc, char **argv)
 	if (con == NULL)
 		exit(1);
 
-	if (PQstatus(con) == CONNECTION_BAD)
-	{
-		pg_log_fatal("connection to database \"%s\" failed: %s",
-					 PQdb(con) ? PQdb(con) : "", PQerrorMessage(con));
-		exit(1);
-	}
-
 	if (internal_script_used)
 		GetTableInfo(con, scale_given);
 


[parent: 75e3cca42d6f]