postgres.git / summary / log / commit / refs

commit    ef777cb093e8cb45dd3ae9d3f1499c765147c1dd
Author:   Tomas Vondra <tomas.vondra@postgresql.org>
Date:     Fri Jul 05 16:06:02 2019 +0000
First released in: 13.0, 12.0

    Remove unused variable in statext_mcv_serialize()
    
    The itemlen variable used to be referenced in multiple places, but since
    reworking the serialization code it's used only in one assert. Fixed by
    removing the variable and calling the macro from the assert directly.
    
    Backpatch to 12, where this code was introduced.
    
    Reported-by: Jeff Janes
    Discussion: https://postgr.es/m/CAMkU=1zc_ovH9NZd_9ovuiEWkF9yX06URUDdXCmgDydf-bqB5A@mail.gmail.com


 src/backend/statistics/mcv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/backend/statistics/mcv.c b/src/backend/statistics/mcv.c
index 136ebddc460..913a72ff673 100644
--- a/src/backend/statistics/mcv.c
+++ b/src/backend/statistics/mcv.c
@@ -911,10 +911,9 @@ statext_mcv_serialize(MCVList *mcvlist, VacAttrStats **stats)
 	for (i = 0; i < mcvlist->nitems; i++)
 	{
 		MCVItem    *mcvitem = &mcvlist->items[i];
-		int			itemlen = ITEM_SIZE(dim);
 
 		/* don't write beyond the allocated space */
-		Assert(ptr <= (endptr - itemlen));
+		Assert(ptr <= (endptr - ITEM_SIZE(dim)));
 
 		/* copy NULL and frequency flags into the serialized MCV */
 		memcpy(ptr, mcvitem->isnull, sizeof(bool) * ndims);


[parent: 02e95a5049f7]