postgres.git / summary / log / commit / refs

commit    efcf55f8fe00b46198cd34557431c87ce5da8040
Author:   Peter Eisentraut <peter@eisentraut.org>
Date:     Thu Jun 29 08:30:55 2023 +0000
First released in: 16.0, 14.9, 15.4

    Remove inappropriate raw_expression_tree_walker() code
    
    It was walking into the ColumnDef->compression field, which is not a
    node but a string.  This code is currently not reachable (because the
    compression field is only set in situations that don't go through
    raw_expression_tree_walker()), but if it had been, this could have
    behaved erratically.


 src/backend/nodes/nodeFuncs.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/backend/nodes/nodeFuncs.c b/src/backend/nodes/nodeFuncs.c
index 0ed8712a631..c41e6bb984c 100644
--- a/src/backend/nodes/nodeFuncs.c
+++ b/src/backend/nodes/nodeFuncs.c
@@ -4262,8 +4262,6 @@ raw_expression_tree_walker_impl(Node *node,
 
 				if (WALK(coldef->typeName))
 					return true;
-				if (WALK(coldef->compression))
-					return true;
 				if (WALK(coldef->raw_default))
 					return true;
 				if (WALK(coldef->collClause))


[parent: 39a584dc9032]