postgres.git / summary / log / commit / refs

commit    efe169c90090684d2a4ffb0810a0cf2c9b72e19d
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Thu Jul 29 02:00:00 2021 +0000

    Add missing exit() in pg_verifybackup when failing to find pg_waldump
    
    pg_verifybackup needs by default pg_waldump to check after a range of
    WAL segments required for a backup, except if --no-parse-wal is
    specified.  The code checked for the presence of the binary pg_waldump
    in an installation and reported an error, but it forgot to properly
    exit().  This could lead to confusing errors reported.
    
    Reviewed-by: Robert Haas, Fabien Coelho
    Discussion: https://postgr.es/m/YQDMdB+B68yePFeT@paquier.xyz
    Backpatch-through: 13


 src/bin/pg_verifybackup/pg_verifybackup.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/bin/pg_verifybackup/pg_verifybackup.c b/src/bin/pg_verifybackup/pg_verifybackup.c
index 20140aa0274..f2ab2c526b9 100644
--- a/src/bin/pg_verifybackup/pg_verifybackup.c
+++ b/src/bin/pg_verifybackup/pg_verifybackup.c
@@ -304,6 +304,7 @@ main(int argc, char **argv)
 							 "but was not the same version as %s.\n"
 							 "Check your installation.",
 							 "pg_waldump", full_path, "pg_verifybackup");
+			exit(1);
 		}
 	}
 


[parent: a66b05b422d7]