postgres.git / summary / log / commit / refs

commit    effcafeaa18b651c30f12077baae484efc6c6368
Author:   Itagaki Takahiro <itagaki.takahiro@gmail.com>
Date:     Wed Jun 09 00:56:25 2010 +0000
First released in: 9.0.0, 7.4.30, 8.0.26, 8.1.22, 8.2.18, 8.3.12, 8.4.5

    Fix connection leak in dblink when dblink_connect() or dblink_connect_u()
    end with "duplicate connection name" errors.
    
    Backported to release 7.4.


 contrib/dblink/dblink.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c
index cde6c329570..b9433fcaa4b 100644
--- a/contrib/dblink/dblink.c
+++ b/contrib/dblink/dblink.c
@@ -8,7 +8,7 @@
  * Darko Prenosil <Darko.Prenosil@finteh.hr>
  * Shridhar Daithankar <shridhar_daithankar@persistent.co.in>
  *
- * $PostgreSQL: pgsql/contrib/dblink/dblink.c,v 1.82.2.3 2010/06/03 09:40:17 itagaki Exp $
+ * $PostgreSQL: pgsql/contrib/dblink/dblink.c,v 1.82.2.4 2010/06/09 00:56:25 itagaki Exp $
  * Copyright (c) 2001-2009, PostgreSQL Global Development Group
  * ALL RIGHTS RESERVED;
  *
@@ -2275,9 +2275,14 @@ createNewConnection(const char *name, remoteConn *rconn)
 											   HASH_ENTER, &found);
 
 	if (found)
+	{
+		PQfinish(rconn->conn);
+		pfree(rconn);
+
 		ereport(ERROR,
 				(errcode(ERRCODE_DUPLICATE_OBJECT),
 				 errmsg("duplicate connection name")));
+	}
 
 	hentry->rconn = rconn;
 	strlcpy(hentry->name, name, sizeof(hentry->name));


[parent: 3b530d90d5d6]