postgrespro.git / summary / log / commit / refs

commit    f16735d80d2fbe1c86f4ac044ee66fe2073b8877
Author:   Thomas Munro <tmunro@postgresql.org>
Date:     Sun Feb 24 10:48:52 2019 +0000

    Tolerate EINVAL when calling fsync() on a directory.
    
    Previously, we tolerated EBADF as a way for the operating system to
    indicate that it doesn't support fsync() on a directory.  Tolerate
    EINVAL too, for older versions of Linux CIFS.
    
    Bug #15636.  Back-patch all the way.
    
    Reported-by: John Klann
    Discussion: https://postgr.es/m/15636-d380890dafd78fc6@postgresql.org


 src/backend/storage/file/fd.c | 2 +-
 src/common/file_utils.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
index d46639d2ed..1ba0ddac10 100644
--- a/src/backend/storage/file/fd.c
+++ b/src/backend/storage/file/fd.c
@@ -3379,7 +3379,7 @@ fsync_fname_ext(const char *fname, bool isdir, bool ignore_perm, int elevel)
 	 * Some OSes don't allow us to fsync directories at all, so we can ignore
 	 * those errors. Anything else needs to be logged.
 	 */
-	if (returncode != 0 && !(isdir && errno == EBADF))
+	if (returncode != 0 && !(isdir && (errno == EBADF || errno == EINVAL)))
 	{
 		int			save_errno;
 
diff --git a/src/common/file_utils.c b/src/common/file_utils.c
index 4bcb9c1e05..c25713d0e5 100644
--- a/src/common/file_utils.c
+++ b/src/common/file_utils.c
@@ -299,7 +299,7 @@ fsync_fname(const char *fname, bool isdir, const char *progname)
 	 * Some OSes don't allow us to fsync directories at all, so we can ignore
 	 * those errors. Anything else needs to be reported.
 	 */
-	if (returncode != 0 && !(isdir && errno == EBADF))
+	if (returncode != 0 && !(isdir && (errno == EBADF || errno == EINVAL)))
 	{
 		fprintf(stderr, _("%s: could not fsync file \"%s\": %s\n"),
 				progname, fname, strerror(errno));


[parent: 483520eca426]