postgres.git / summary / log / commit / refs

commit    f1eafd911ddde87f84672b5bf227a3e6cae6331f
Author:   Jacob Champion <jchampion@postgresql.org>
Date:     Thu Oct 08 17:58:07 2026 +0000

    oauth_validator: Remove racing GUC check
    
    Follow-up to bca67e5a3. The test added there changed the value of
    oauth_validator_libraries, waited for the postmaster to apply it, and
    verified the change on an existing background connection. But there's no
    guarantee that the SIGHUP will have arrived and completed its work on
    existing backends by that time, so the final test flaked.
    
    We only care about the postmaster's state here, since we're testing the
    GUC's effects on newly forked backends, so remove the background check
    entirely.
    
    Per buildfarm member serinus.
    
    Reported-by: Alexander Lakhin <exclusion@gmail.com>
    Discussion: https://postgr.es/m/a37a3cea-5bd8-4385-a1d4-bb89394c079c%40gmail.com
    Backpatch-through: 18


 src/test/modules/oauth_validator/t/001_server.pl | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/test/modules/oauth_validator/t/001_server.pl b/src/test/modules/oauth_validator/t/001_server.pl
index fb76c69c1ca..444de01ea5d 100644
--- a/src/test/modules/oauth_validator/t/001_server.pl
+++ b/src/test/modules/oauth_validator/t/001_server.pl
@@ -149,8 +149,6 @@ $node->reload;
 $log_start = $node->wait_for_log(
 	qr/parameter "oauth_validator_libraries" changed to "validator"/,
 	$log_start);
-is($bgconn->query_safe('SHOW oauth_validator_libraries'),
-	'validator', 'oauth_validator_libraries restored');
 
 {
 	# Make sure PGOAUTHDEBUG=UNSAFE doesn't disable certificate verification.


[parent: c652cd3f94d5]