postgres.git / summary / log / commit / refs

commit    f2a3cdb6dbe4984c7b5461ed4ece789eab2faf4a
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Tue Dec 16 19:53:58 2014 +0000
First released in: 9.5.0, 9.4.1

    Suppress bogus statistics when pgbench failed to complete any transactions.
    
    Code added in 9.4 would attempt to divide by zero in such cases.
    Noted while testing fix for missing-pclose problem.


 contrib/pgbench/pgbench.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/contrib/pgbench/pgbench.c b/contrib/pgbench/pgbench.c
index bd5e265b84b..ed7fc1946eb 100644
--- a/contrib/pgbench/pgbench.c
+++ b/contrib/pgbench/pgbench.c
@@ -2299,6 +2299,10 @@ printResults(int ttype, int64 normal_xacts, int nclients,
 			   normal_xacts);
 	}
 
+	/* Remaining stats are nonsensical if we failed to execute any xacts */
+	if (normal_xacts <= 0)
+		return;
+
 	if (throttle_delay || progress)
 	{
 		/* compute and show latency average and standard deviation */


[parent: 6c75384eed87]