postgres.git / summary / log / commit / refs

commit    f371a4cdba6dc805acd608cc63a7089b57cb4e9e
Author:   Robert Haas <rhaas@postgresql.org>
Date:     Sat Mar 13 00:00:41 2021 +0000

    Try to avoid apparent platform-dependency in IPC::Run
    
    It's hard to believe, but buildfarm results from the new pg_amcheck
    suggest that command_checks_all() perform shell expansion on some
    machines but not others, apparently due to an underlying behavior
    difference in IPC::Run. Let's see if we can work around that - and
    confirm that it is the real problem - by passing '-S*' as a single
    argument rather than '-S' and '*' as two separate ones.
    
    Failures were observed on jacana and hoverfly.
    
    Mark Dilger
    
    Discussion: http://postgr.es/m/9E76E46A-48B2-4869-BD0C-422204C1F767@enterprisedb.com


 src/bin/pg_amcheck/t/002_nonesuch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/pg_amcheck/t/002_nonesuch.pl b/src/bin/pg_amcheck/t/002_nonesuch.pl
index b7d41c9b49e..a2c3537f14a 100644
--- a/src/bin/pg_amcheck/t/002_nonesuch.pl
+++ b/src/bin/pg_amcheck/t/002_nonesuch.pl
@@ -239,7 +239,7 @@ $node->command_checks_all(
 		'-s', 'pg_toast',
 		'-s', 'information_schema',
 		'-t', 'pg_catalog.pg_class',
-		'-S', '*'
+		'-S*'
 	],
 	1,
 	[ qr/^$/ ],


[parent: 661125612706]