postgres.git / summary / log / commit / refs

commit    f3fb145a0adb2c0ae34f4e36cf55bb1d60df3ddd
Author:   Amit Langote <amitlan@postgresql.org>
Date:     Thu Apr 16 02:52:16 2026 +0000
First released in: 17.10, 18.4

    Fix incorrect comment in JsonTablePlanJoinNextRow()
    
    The comment on the return-false path when both UNION siblings are
    exhausted said "there are more rows," which is the opposite of what
    the code does. The code itself is correct, returning false to signal
    no more rows, but the misleading comment could tempt a reader into
    "fixing" the return value, which would cause UNION plans to loop
    indefinitely.
    
    Back-patch to 17, where JSON_TABLE was introduced.
    
    Author: Chuanwen Hu <463945512@qq.com>
    Reviewed-by: Chao Li <li.evan.chao@gmail.com>
    Discussion: https://postgr.es/m/tencent_4CC6316F02DECA61ACCF22F933FEA5C12806@qq.com
    Backpatch-through: 17


 src/backend/utils/adt/jsonpath_exec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/utils/adt/jsonpath_exec.c b/src/backend/utils/adt/jsonpath_exec.c
index dbab24737ef..eedc5c87b05 100644
--- a/src/backend/utils/adt/jsonpath_exec.c
+++ b/src/backend/utils/adt/jsonpath_exec.c
@@ -4419,7 +4419,7 @@ JsonTablePlanJoinNextRow(JsonTablePlanState *planstate)
 		 */
 		if (!JsonTablePlanNextRow(planstate->right))
 		{
-			/* Right sibling ran out of row, so there are more rows. */
+			/* Right sibling ran out of rows too, so there are no more rows. */
 			return false;
 		}
 	}


[parent: ca938ec213d9]