pgpool2.git / summary / log / commit / refs

commit    f4494cf60a758d29760293720ddbfb5641e677c4
Author:   Tatsuo Ishii <ishii@postgresql.org>
Date:     Sat Jul 21 22:31:46 2012 +0000

    Fix bug with previous patch in schema qualified table name case.


 pool_select_walker.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/pool_select_walker.c b/pool_select_walker.c
index ddd27701a..17799dbaf 100644
--- a/pool_select_walker.c
+++ b/pool_select_walker.c
@@ -1044,7 +1044,14 @@ makeRangeVarFromNameList(List *names)
  */
 static char *make_table_name_from_rangevar(RangeVar *rangevar)
 {
-	static char tablename[POOL_NAMEDATALEN*2+1];
+	/*
+	 * Table name. Max size is calculated as follows:
+	 * schema name(POOL_NAMEDATALEN byte)
+	 * + single quote(1 byte)
+	 * + table name (POOL_NAMEDATALEN byte)
+	 * + NULL(1 byte)
+	 */
+	static char tablename[POOL_NAMEDATALEN*2+1+1];
 
 	if (rangevar == NULL)
 	{
@@ -1064,6 +1071,7 @@ static char *make_table_name_from_rangevar(RangeVar *rangevar)
 	if (rangevar->schemaname)
 	{
 		strncpy(tablename, rangevar->schemaname, POOL_NAMEDATALEN);
+		strcat(tablename, ".");
 	}
 
 	if (!rangevar->relname)


[parent: e0fcc5da5282]