postgres.git / summary / log / commit / refs

commit    f4b3ab537fe2657243c2f7aa02bf9d137b48a255
Author:   Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date:     Mon Jul 12 08:13:33 2021 +0000
First released in: 15.0, 9.6.23, 10.18, 11.13, 12.8, 13.4, 14.0

    Remove dead assignment to local variable.
    
    This should have been removed in commit 7e30c186da, which split the loop
    into two. Only the first loop uses the 'from' variable; updating it in
    the second loop is bogus. It was never read after the first loop, so this
    was harmless and surely optimized away by the compiler, but let's be tidy.
    
    Backpatch to all supported versions.
    
    Author: Ranier Vilela
    Discussion: https://www.postgresql.org/message-id/CAEudQAoWq%2BAL3BnELHu7gms2GN07k-np6yLbukGaxJ1vY-zeiQ%40mail.gmail.com


 src/backend/access/nbtree/nbtxlog.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/backend/access/nbtree/nbtxlog.c b/src/backend/access/nbtree/nbtxlog.c
index 1ecdeb3fb68..38b6169da47 100644
--- a/src/backend/access/nbtree/nbtxlog.c
+++ b/src/backend/access/nbtree/nbtxlog.c
@@ -75,7 +75,6 @@ _bt_restore_page(Page page, char *from, int len)
 		if (PageAddItem(page, items[i], itemsizes[i], nitems - i,
 						false, false) == InvalidOffsetNumber)
 			elog(PANIC, "_bt_restore_page: cannot add item to page");
-		from += itemsz;
 	}
 }
 


[parent: 6bd9ae173d37]