postgres.git / summary / log / commit / refs

commit    f5acde9380e164eab10b2dc3281bb1c07f690803
Author:   Stephen Frost <sfrost@snowman.net>
Date:     Sun Jul 14 19:31:23 2013 +0000
First released in: 9.4.0, 9.3.0

    pg_receivexlog - Exit on failure to parse
    
    In streamutil.c:GetConnection(), upgrade failure to parse the
    connection string to an exit(1) instead of simply returning NULL.
    Most callers already immediately exited, but pg_receivexlog would
    loop on this case, continually trying to re-parse the connection
    string (which can't be changed after pg_receivexlog has started).
    
    GetConnection() was already expected to exit(1) in some cases
    (eg: failure to allocate memory or if unable to determine the
    integer_datetimes flag), so this change shouldn't surprise anyone.
    
    Began looking at this due to the Coverity scanner complaining that
    we were leaking err_msg in this case- no longer an issue since we
    just exit(1) immediately.


 src/bin/pg_basebackup/streamutil.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/pg_basebackup/streamutil.c b/src/bin/pg_basebackup/streamutil.c
index 6891c2c8105..dab0e5470cf 100644
--- a/src/bin/pg_basebackup/streamutil.c
+++ b/src/bin/pg_basebackup/streamutil.c
@@ -57,7 +57,7 @@ GetConnection(void)
 		if (conn_opts == NULL)
 		{
 			fprintf(stderr, "%s: %s\n", progname, err_msg);
-			return NULL;
+			exit(1);
 		}
 
 		for (conn_opt = conn_opts; conn_opt->keyword != NULL; conn_opt++)


[parent: 8839e7362c68]