pgpool2.git / summary / log / commit / refs

commit    f7eccd2f32a62fa30bd57cd73334648e97c60c70
Author:   Muhammad Usama <m.usama@gmail.com>
Date:     Thu Oct 03 20:25:17 2019 +0000

    Fix for Coverity warning '1395047 Resource leak'


 src/config/pool_config_variables.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/config/pool_config_variables.c b/src/config/pool_config_variables.c
index 1cdf3ed23..308f54a21 100644
--- a/src/config/pool_config_variables.c
+++ b/src/config/pool_config_variables.c
@@ -2709,7 +2709,6 @@ get_list_from_string_regex_delim(const char *input, const char *delimi, int *n)
 {
 #ifndef POOL_PRIVATE
 	int			j = 0;
-	char	   *output;
 	char	   *str;
 	char	   *buf,
 			   *str_temp;
@@ -2746,12 +2745,12 @@ get_list_from_string_regex_delim(const char *input, const char *delimi, int *n)
 		}
 		else if (*str_temp == *delimi)
 		{
-			output = (char *) palloc(j + 1);
+			char *output = (char *) palloc(j + 1);
 			StrNCpy(output, buf, j + 1);
 
 			/* replace escape character of "'" */
 			tokens[*n] = string_replace(output, "\\'", "'");
-
+			pfree(output);
 			ereport(DEBUG3,
 					(errmsg("initializing pool configuration"),
 					 errdetail("extracting string tokens [token[%d]: %s]", *n, tokens[*n])));


[parent: a33d835f807e]