postgrespro.git / summary / log / commit / refs

commit    f86f46d091a6876fbf28e0a4a87ca72b560cf77f
Author:   Peter Eisentraut <peter@eisentraut.org>
Date:     Tue Oct 22 07:58:20 2019 +0000

    Fix comment
    
    The last argument of smgrextend() was renamed from isTemp to skipFsync
    in debcec7dc31a992703911a9953e299c8d730c778, but the comments at two
    call sites were not updated.


 src/backend/access/heap/rewriteheap.c | 7 +++----
 src/backend/catalog/storage.c         | 6 +++---
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/src/backend/access/heap/rewriteheap.c b/src/backend/access/heap/rewriteheap.c
index 306e74ea10..d41dbcf5f7 100644
--- a/src/backend/access/heap/rewriteheap.c
+++ b/src/backend/access/heap/rewriteheap.c
@@ -703,10 +703,9 @@ raw_heap_insert(RewriteState state, HeapTuple tup)
 							true);
 
 			/*
-			 * Now write the page. We say isTemp = true even if it's not a
-			 * temp table, because there's no need for smgr to schedule an
-			 * fsync for this write; we'll do it ourselves in
-			 * end_heap_rewrite.
+			 * Now write the page. We say skipFsync = true because there's no
+			 * need for smgr to schedule an fsync for this write; we'll do it
+			 * ourselves in end_heap_rewrite.
 			 */
 			RelationOpenSmgr(state->rs_new_rel);
 
diff --git a/src/backend/catalog/storage.c b/src/backend/catalog/storage.c
index b8c9b6f9c6..625af8d49a 100644
--- a/src/backend/catalog/storage.c
+++ b/src/backend/catalog/storage.c
@@ -390,9 +390,9 @@ RelationCopyStorage(SMgrRelation src, SMgrRelation dst,
 		PageSetChecksumInplace(page, blkno);
 
 		/*
-		 * Now write the page.  We say isTemp = true even if it's not a temp
-		 * rel, because there's no need for smgr to schedule an fsync for this
-		 * write; we'll do it ourselves below.
+		 * Now write the page.  We say skipFsync = true because there's no
+		 * need for smgr to schedule an fsync for this write; we'll do it
+		 * ourselves below.
 		 */
 		smgrextend(dst, forkNum, blkno, buf.data, true);
 	}


[parent: 52ad1e659967]