postgres.git / summary / log / commit / refs

commit    f9993ac646b9db202a2aa3d18444e0971b63e21f
Author:   Álvaro Herrera <alvherre@kurilemu.de>
Date:     Sat Oct 11 14:39:22 2025 +0000
First released in: 15.15, 16.11, 17.7, 18.1

    dbase_redo: Fix Valgrind-reported memory leak
    
    Introduced by my (Álvaro's) commit 9e4f914b5eba, which was itself
    backpatched to pg10, though only pg15 and up contain the problem
    because of commit 9c08aea6a309.
    
    This isn't a particularly significant leak, but given the fix is
    trivial, we might as well backpatch to all branches where it applies, so
    do that.
    
    Author: Nathan Bossart <nathandbossart@gmail.com>
    Reported-by: Andres Freund <andres@anarazel.de>
    Discussion: https://postgr.es/m/x4odfdlrwvsjawscnqsqjpofvauxslw7b4oyvxgt5owoyf4ysn@heafjusodrz7


 src/backend/commands/dbcommands.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/backend/commands/dbcommands.c b/src/backend/commands/dbcommands.c
index 2505b3084b0..f529e0ff129 100644
--- a/src/backend/commands/dbcommands.c
+++ b/src/backend/commands/dbcommands.c
@@ -3359,6 +3359,7 @@ dbase_redo(XLogReaderState *record)
 		parent_path = pstrdup(dbpath);
 		get_parent_directory(parent_path);
 		recovery_create_dbdir(parent_path, true);
+		pfree(parent_path);
 
 		/* Create the database directory with the version file. */
 		CreateDirAndVersionFile(dbpath, xlrec->db_id, xlrec->tablespace_id,


[parent: ae15cebc2035]