postgres.git / summary / log / commit / refs
commit f9aa8763e293ad81bd3a2f7b2e3849631b77f762
Author: Greg Stark <stark@mit.edu>
Date: Tue Feb 16 00:01:11 2010 +0000
First released in: 8.1.20, 8.2.16, 8.3.10, 8.4.3
revert prior patch to fsync directories until portability problems exposed by build farm can be sorted out
src/port/copydir.c | 23 +----------------------
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/src/port/copydir.c b/src/port/copydir.c
index 4cc6e4e0b6f..cfdaddb28ce 100644
--- a/src/port/copydir.c
+++ b/src/port/copydir.c
@@ -11,7 +11,7 @@
* as a service.
*
* IDENTIFICATION
- * $PostgreSQL: pgsql/src/port/copydir.c,v 1.18.2.2 2010/02/14 17:50:39 stark Exp $
+ * $PostgreSQL: pgsql/src/port/copydir.c,v 1.18.2.3 2010/02/16 00:01:11 stark Exp $
*
*-------------------------------------------------------------------------
*/
@@ -50,7 +50,6 @@ copydir(char *fromdir, char *todir, bool recurse)
{
DIR *xldir;
struct dirent *xlde;
- int dirfd;
char fromfile[MAXPGPATH];
char tofile[MAXPGPATH];
@@ -92,26 +91,6 @@ copydir(char *fromdir, char *todir, bool recurse)
}
FreeDir(xldir);
-
- /*
- * fsync the directory to make sure not just the data but also the
- * new directory file entries have reached the disk. While needed
- * by most filesystems, the window got bigger with newer ones like
- * ext4.
- */
- dirfd = BasicOpenFile(todir,
- O_RDONLY | PG_BINARY,
- S_IRUSR | S_IWUSR);
- if(dirfd == -1)
- ereport(ERROR,
- (errcode_for_file_access(),
- errmsg("could not open directory for fsync \"%s\": %m", todir)));
-
- if(pg_fsync(dirfd) == -1)
- ereport(ERROR,
- (errcode_for_file_access(),
- errmsg("could not fsync directory \"%s\": %m", todir)));
- close(dirfd);
}
/*
[parent: 1534023ff0bd]