postgres.git / summary / log / commit / refs

commit    fa7d5b704a3786be0f3e3334dd506fe8a46b02bc
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Sat Jul 28 22:53:11 2018 +0000

    Add verbosity to pg_basebackup for sync
    
    This is useful to know when the data copy has been finished.  The
    current situation can be confusing for users as the last message is
    "waiting for background process to finish streaming", so it looks like
    this is taking time but the final sync is instead.
    
    Author: Jeff Janes
    Discussion: https://postgr.es/m/CAMkU=1ypeoMJ=tFBG8vP13sxEtXd4Pm_x1SqsJdW_RvzpcvN=A@mail.gmail.com


 src/bin/pg_basebackup/pg_basebackup.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
index ef4cfc43847..96a4dce4bf4 100644
--- a/src/bin/pg_basebackup/pg_basebackup.c
+++ b/src/bin/pg_basebackup/pg_basebackup.c
@@ -2112,6 +2112,9 @@ BaseBackup(void)
 	 */
 	if (do_sync)
 	{
+		if (verbose)
+			fprintf(stderr,
+					_("%s: syncing data to disk ...\n"), progname);
 		if (format == 't')
 		{
 			if (strcmp(basedir, "-") != 0)


[parent: e2c0df7828b9]