postgrespro.git / summary / log / commit / refs

commit    fb57f40eec503d637bf01c298f5cb2472f0d4fdb
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Mon Aug 26 21:02:52 2019 +0000

    Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.
    
    If a test case tried to set an invalid value of synchronous_standby_names,
    the test script didn't detect that, which seems like a bad idea.
    Noticed while testing a proposed patch that broke some of these
    test cases.


src/test/recovery/t/007_sync_rep.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/recovery/t/007_sync_rep.pl b/src/test/recovery/t/007_sync_rep.pl index eccde8f551..05803bed4e 100644 --- a/src/test/recovery/t/007_sync_rep.pl +++ b/src/test/recovery/t/007_sync_rep.pl @@ -18,7 +18,7 @@ sub test_sync_state if (defined($setting)) { - $self->psql('postgres', + $self->safe_psql('postgres', "ALTER SYSTEM SET synchronous_standby_names = '$setting';"); $self->reload; } [parent: ee3278239550]