postgres.git / summary / log / commit / refs

commit    fcbd1bb6613fde5784b54c88e4d0398ab8e13694
Author:   David Rowley <drowley@postgresql.org>
Date:     Tue Oct 29 12:38:42 2024 +0000
First released in: 18.0

    Reduce variable scope and possibly useless palloc
    
    Move the CreateStmt down to the branch that it's used in, thus
    preventing the makeNode() call in cases where the CreateStmt isn't used.
    
    Author: Ranier Vilela <ranier.vf@gmail.com>
    Discussion: https://postgr.es/m/CAEudQAq=06YPWPhS+yyTbCwv5JLKRz8rm3dWx6JR5Uj_d_fQDA@mail.gmail.com


 src/backend/commands/view.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/commands/view.c b/src/backend/commands/view.c
index fdad8338324..2bd49eb55e6 100644
--- a/src/backend/commands/view.c
+++ b/src/backend/commands/view.c
@@ -47,7 +47,6 @@ DefineVirtualRelation(RangeVar *relation, List *tlist, bool replace,
 {
 	Oid			viewOid;
 	LOCKMODE	lockmode;
-	CreateStmt *createStmt = makeNode(CreateStmt);
 	List	   *attrList;
 	ListCell   *t;
 
@@ -223,6 +222,7 @@ DefineVirtualRelation(RangeVar *relation, List *tlist, bool replace,
 	}
 	else
 	{
+		CreateStmt *createStmt = makeNode(CreateStmt);
 		ObjectAddress address;
 
 		/*


[parent: 84b8fccbe5c2]