postgres.git / summary / log / commit / refs

commit    fd1eaf9202dc3bbd657aa1f46b787329173b261c
Author:   Etsuro Fujita <efujita@postgresql.org>
Date:     Tue Mar 12 07:32:27 2019 +0000
First released in: 12.0, 11.3

    Fix testing of parallel-safety of scan/join target.
    
    In commit 960df2a971 ("Correctly assess parallel-safety of tlists when
    SRFs are used."), the testing of scan/join target was done incorrectly,
    which caused a plan-quality problem.  Backpatch through to v11 where
    the aforementioned commit went in, since this is a regression from v10.
    
    Author: Etsuro Fujita
    Reviewed-by: Robert Haas and Tom Lane
    Discussion: https://postgr.es/m/5C75303E.8020303@lab.ntt.co.jp


 src/backend/optimizer/plan/planner.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c
index 680085096ae..03589da0134 100644
--- a/src/backend/optimizer/plan/planner.c
+++ b/src/backend/optimizer/plan/planner.c
@@ -1992,7 +1992,7 @@ grouping_planner(PlannerInfo *root, bool inheritance_update,
 		{
 			scanjoin_target = make_group_input_target(root, final_target);
 			scanjoin_target_parallel_safe =
-				is_parallel_safe(root, (Node *) grouping_target->exprs);
+				is_parallel_safe(root, (Node *) scanjoin_target->exprs);
 		}
 		else
 		{


[parent: e7adda86ba9c]