postgres.git / summary / log / commit / refs

commit    fd3dfc236c155048caf21c35e23e8dadc89895ec
Author:   Andres Freund <andres@anarazel.de>
Date:     Mon Apr 27 22:12:38 2015 +0000
First released in: 9.5.0, 9.4.2

    Use a fd opened for read/write when syncing slots during startup.
    
    Some operating systems, including the reporter's windows, return EBADFD
    or similar when fsync() is invoked on a O_RDONLY file descriptor.
    Unfortunately RestoreSlotFromDisk() does exactly that; which causes
    failures after restarts in at least some scenarios.
    
    If you hit the bug the error message will be something like
    ERROR: could not fsync file "pg_replslot/$name/state": Bad file descriptor
    
    Simply use O_RDWR instead of O_RDONLY when opening the relevant file
    descriptor to fix the bug.  Unfortunately I have no way of verifying the
    fix, but we've seen similar problems in the past.
    
    This bug goes back to 9.4 where slots were introduced. Backpatch
    accordingly.
    
    Reported-By: Patrice Drolet
    Bug: #13143:
    Discussion: 20150424101006.2556.60897@wrigleys.postgresql.org


 src/backend/replication/slot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/replication/slot.c b/src/backend/replication/slot.c
index 5a7d021f585..e0929cd00ba 100644
--- a/src/backend/replication/slot.c
+++ b/src/backend/replication/slot.c
@@ -1091,7 +1091,7 @@ RestoreSlotFromDisk(const char *name)
 
 	elog(DEBUG1, "restoring replication slot from \"%s\"", path);
 
-	fd = OpenTransientFile(path, O_RDONLY | PG_BINARY, 0);
+	fd = OpenTransientFile(path, O_RDWR | PG_BINARY, 0);
 
 	/*
 	 * We do not need to handle this as we are rename()ing the directory into


[parent: 5f3d1909c58a]