postgres.git / summary / log / commit / refs

commit    fd7a114dbb4e8b700b0b738bb9c513b5fa3198a3
Author:   Andres Freund <andres@anarazel.de>
Date:     Mon Sep 25 18:50:02 2023 +0000
First released in: 17.0, 11.22, 12.17, 13.13, 14.10, 15.5, 16.1

    pg_dump: tests: Correct test condition for invalid databases
    
    For some reason I used not_like = { pg_dumpall_dbprivs => 1, } in the test
    condition of one of the tests added in in c66a7d75e65. That doesn't make sense
    for two reasons: 1) not_like isn't a valid test condition 2) the database
    should not be dumped in any of the tests.  Due to 1), the test achieved its
    goal, but clearly the formulation is confusing.  Instead use like => {}, with
    a comment explaining why.
    
    Reported-by: Peter Eisentraut <peter@eisentraut.org>
    Discussion: https://postgr.es/m/3ddf79f2-8b7b-a093-11d2-5c739bc64f86@eisentraut.org
    Backpatch: 11-, like c66a7d75e65


src/bin/pg_dump/t/002_pg_dump.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bin/pg_dump/t/002_pg_dump.pl b/src/bin/pg_dump/t/002_pg_dump.pl index 50e70113a01..ce5730977a9 100644 --- a/src/bin/pg_dump/t/002_pg_dump.pl +++ b/src/bin/pg_dump/t/002_pg_dump.pl @@ -1434,9 +1434,9 @@ my %tests = ( CREATE DATABASE regression_invalid; UPDATE pg_database SET datconnlimit = -2 WHERE datname = 'regression_invalid'), regexp => qr/^CREATE DATABASE regression_invalid/m, - not_like => { - pg_dumpall_dbprivs => 1, - }, + + # invalid databases should never be dumped + like => {}, }, 'CREATE ACCESS METHOD gist2' => { [parent: 4435a8d5dbab]