postgres.git / summary / log / commit / refs

commit    fe323438140f69b8122e618387db1beb9ddaf5d3
Author:   Amit Langote <amitlan@postgresql.org>
Date:     Fri Sep 06 01:12:00 2024 +0000
First released in: 18.0, 17.0

    Update comment about ExprState.escontext
    
    The updated comment provides more helpful guidance by mentioning that
    escontext should be set when soft error handling is needed.
    
    Reported-by: Jian He <jian.universality@gmail.com>
    Discussion: https://postgr.es/m/CACJufxEo4sUjKCYtda0_qt9tazqqKPmF1cqhW9KBOUeJFqQd2g@mail.gmail.com
    Backpatch-through: 17


 src/include/nodes/execnodes.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h
index b62c96f2064..cd1b16296b5 100644
--- a/src/include/nodes/execnodes.h
+++ b/src/include/nodes/execnodes.h
@@ -132,8 +132,10 @@ typedef struct ExprState
 	bool	   *innermost_domainnull;
 
 	/*
-	 * For expression nodes that support soft errors.  Should be set to NULL
-	 * before calling ExecInitExprRec() if the caller wants errors thrown.
+	 * For expression nodes that support soft errors. Should be set to NULL if
+	 * the caller wants errors to be thrown. Callers that do not want errors
+	 * thrown should set it to a valid ErrorSaveContext before calling
+	 * ExecInitExprRec().
 	 */
 	ErrorSaveContext *escontext;
 } ExprState;


[parent: 35afec71aeb3]