pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Alexander Lakhin <exclusion@gmail.com>
To: jian he <jian.universality@gmail.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Thom Brown <thom@linux.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Himanshu Upadhyaya <upadhyaya.himanshu@gmail.com>
Cc: Erik Rijkers <er@xs4all.nl>
Cc: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: remaining sql/json patches
Date: Wed, 26 Jun 2024 14:00:00 +0300
Message-ID: <058c856a-e090-ac42-ff00-ffe394f52a87@gmail.com> (raw)
In-Reply-To: <CACJufxHtMjiCdYovDmRaUAAiHihPFtdieQy7e+dV=sdE5aY7+Q@mail.gmail.com>
References: <CA+HiwqHx0kAe74hXY-M3GVqZAmZWx+GuAksjcG4iK-ZHoaeBLg@mail.gmail.com>
	<CA+HiwqFi7aaYn4xSaRxdE5w9Yt=O3XwEH_LE+nu+bpKi65RwRg@mail.gmail.com>
	<CACJufxHh8LicHPaisn9CEBhEoWismR4Z2FRKXXxpnMnZamRB5g@mail.gmail.com>
	<CA+HiwqHi=BM2kPz2d4GHaW82y8RzW_HTF4vZ=cTCvgivW1K3og@mail.gmail.com>
	<CACJufxH4ENG+iuhnGzm=rzyt61faXqkh4SESmpWS_h_jqVowNA@mail.gmail.com>
	<CACJufxGcmwjmu+H7PsMGG2Q=O50FKr2g8uaa3FR9RcbLJ5_+Mw@mail.gmail.com>
	<CA+HiwqHWqob7ao090RhUDVc4vy_WtgM_REi5WLwp+qWmVNQ4Ew@mail.gmail.com>
	<CACJufxHCpGeB7Eu7VR3S57T0KYzgBfZdu8Au4as2kZb_=T0Twg@mail.gmail.com>
	<CACJufxG-So1N7KWMMO0x-tUNo+DWDzqkYtGOQi6yogV5_eS1Xw@mail.gmail.com>
	<CACJufxGB9wC0K4yTxo8xmGrkPRW-M6TMA5V+rpKsxgHwJ7+NKg@mail.gmail.com>
	<CA+HiwqFosrEbh_9KPX5hsd+n80F1m6CSVgNLYtvhhO1fsrBk6w@mail.gmail.com>
	<CAA-aLv7Dfy9BMrhUZ1skcg=OdqysWKzObS7XiDXdotJNF0E44Q@mail.gmail.com>
	<CA+HiwqGdineyHfcTEe0=8jjXonH3qXi4vFB+gRxf1L+xR2v_Pw@mail.gmail.com>
	<CACJufxHtMjiCdYovDmRaUAAiHihPFtdieQy7e+dV=sdE5aY7+Q@mail.gmail.com>

Hello,

I'm not sure I've chosen the most appropriate thread for reporting the
issue, but maybe you would like to look at code comments related to
SQL/JSON constructors:

  * Transform JSON_ARRAY() constructor.
  *
  * JSON_ARRAY() is transformed into json[b]_build_array[_ext]() call
  * depending on the output JSON format. The first argument of
  * json[b]_build_array_ext() is absent_on_null.


  * Transform JSON_OBJECT() constructor.
  *
  * JSON_OBJECT() is transformed into json[b]_build_object[_ext]() call
  * depending on the output JSON format. The first two arguments of
  * json[b]_build_object_ext() are absent_on_null and check_unique.

But the referenced functions were removed at [1]; Nikita Glukhov wrote:
> I have removed json[b]_build_object_ext() and json[b]_build_array_ext().

(That thread seems too old for the current discussion.)

Also, a comment above transformJsonObjectAgg() references
json[b]_objectagg[_unique][_strict](key, value), but I could find
json_objectagg() only.

[1] https://www.postgresql.org/message-id/be40362b-7821-7422-d33f-fbf1c61bb3e3%40postgrespro.ru

Best regards,
Alexander





view thread (300+ messages)  latest in thread

Message-ID: <058c856a-e090-ac42-ff00-ffe394f52a87@gmail.com>
Permalink:  ../058c856a-e090-ac42-ff00-ffe394f52a87@gmail.com/
Also on:    postgresql.org/message-id/058c856a-e090-ac42-ff00-ffe394f52a87@gmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: exclusion@gmail.com, jian.universality@gmail.com, amitlangote09@gmail.com, thom@linux.com, alvherre@alvh.no-ip.org, tomas.vondra@enterprisedb.com, upadhyaya.himanshu@gmail.com, er@xs4all.nl, andres@anarazel.de, andrew@dunslane.net
  Subject: Re: remaining sql/json patches
  In-Reply-To: <058c856a-e090-ac42-ff00-ffe394f52a87@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox