From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Newline after --progress report
Date: Mon, 17 Aug 2020 09:59:39 -0400
Message-ID: <1069283.1597672779@sss.pgh.pa.us> (raw)
In-Reply-To: <e4759a4d-4cf7-ca08-f0b8-d1cbd4721dc7@iki.fi>
References: <82b539e5-ae33-34b0-1aee-22b3379fd3eb@iki.fi>
<572250.1597413104@sss.pgh.pa.us>
<e4759a4d-4cf7-ca08-f0b8-d1cbd4721dc7@iki.fi>
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> Good point. Pushed a patch along those lines.
Uh ... you patched v12 but not v13?
Also, I'd recommend that you NOT do this:
+ fprintf(stderr, (!finished && isatty(fileno(stderr))) ? "\r" : "\n");
as it breaks printf format verification in many/most compilers.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, hlinnaka@iki.fi
Subject: Re: Newline after --progress report
In-Reply-To: <1069283.1597672779@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox