pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Sigh, I broke crake again
Date: Tue, 27 Feb 2018 13:36:59 -0500
Message-ID: <11927.1519756619@sss.pgh.pa.us> (raw)

I just committed some regression test cleanup that removed or renamed
a couple of C-language functions in regress.so.  I see that crake is
now failing XversionUpgrade tests, and although I can't see the details,
I bet the problem is from trying to load CREATE FUNCTION commands from
the old regression databases that now don't point to an existing C
function.

Does it seem practical to adjust TestUpgradeXversion.pm to cope with
this change?  An alternative answer is to put back C-language stubs
in regress.c for the removed functions, but that seems a bit grotty.

			regards, tom lane




view thread (5+ messages)  latest in thread

Message-ID: <11927.1519756619@sss.pgh.pa.us>
Permalink:  ../11927.1519756619@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/11927.1519756619@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
  Subject: Re: Sigh, I broke crake again
  In-Reply-To: <11927.1519756619@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox