From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Unportable implementation of background worker start
Date: Thu, 27 Apr 2017 16:35:29 -0400
Message-ID: <12307.1493325329@sss.pgh.pa.us> (raw)
In-Reply-To: <20170427011033.csoil7rwkwv4ye5n@alap3.anarazel.de>
References: <20170421151941.45njrtwykn5dd476@alvherre.pgsql>
<18193.1492793404@sss.pgh.pa.us>
<9205.1492833041@sss.pgh.pa.us>
<20170422055444.mfqhrohbjc5jxjdc@alap3.anarazel.de>
<8322.1493240739@sss.pgh.pa.us>
<20170427011033.csoil7rwkwv4ye5n@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Andres Freund <andres@anarazel.de> writes:
> On 2017-04-26 17:05:39 -0400, Tom Lane wrote:
>> I went ahead and changed the call to epoll_create into epoll_create1.
>> I'm not too concerned about loss of portability there --- it seems
>> unlikely that many people are still using ten-year-old glibc, and
>> even less likely that any of them would be interested in running
>> current Postgres on their stable-unto-death platform. We could add
>> a configure test for epoll_create1 if you feel one's needed, but
>> I think it'd just be a waste of cycles.
> Yea, I think we can live with that. If we find it's a problem, we can
> add a configure test later.
Well, according to the buildfarm, "later" is "now" :-(.
If RHEL5 is too old to have epoll_create1, I think your dates for it
might be a bit off. Anyway, I'll go do something about that in a
little bit.
It looks like it might be sufficient to do "#ifdef EPOLL_CLOEXEC"
in latch.c, rather than bothering with a full-blown configure check.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, alvherre@2ndquadrant.com
Subject: Re: Unportable implementation of background worker start
In-Reply-To: <12307.1493325329@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox