pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Ivan Kush <ivan.kush@tantorlabs.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: lev.nikolaev@tantorlabs.com
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER
Date: Wed, 09 Jul 2025 13:36:26 -0400
Message-ID: <1328170.1752082586@sss.pgh.pa.us> (raw)
In-Reply-To: <CAOYmi+=ORLb7mYdLRyrBE5ZGKd74HC4akLF-Vky-yPZCH38=yQ@mail.gmail.com>
References: <83C44AB4-24B0-437F-B139-B5CBC5821BB1@yesql.se>
	<CA+hUKGJ+WyJ26QGvO_nkgvbxgw+03U4EQ4Hxw+QBft6Np+XW7w@mail.gmail.com>
	<CAOYmi+mf+hw7x+E3XkRypEGy=yR3n6zowjjXeXaSK20WxX3UGw@mail.gmail.com>
	<CAOYmi+kr-Eh7utEDZBFq8Mc9byLLRF3ZNc0TaHt78SKwB4T5KA@mail.gmail.com>
	<CA+hUKGL3yYmKmNHw1wnpuhCbqaiDw1DDUhghEDrh6y97Ygzw9Q@mail.gmail.com>
	<CAOYmi+kOyST1DoF1WOMQvf75L56LiLHZR2+3qTJ+QCg2KC8raQ@mail.gmail.com>
	<CA+hUKGL59uY=UpCHEmTL6dpzuWJBVf1Kc4bQADYDEWG9ZDCffA@mail.gmail.com>
	<CAOYmi+k6HUMK4XQAfnxsmgs1oPOKnchyj2O2a+R7H9jOTU4LPQ@mail.gmail.com>
	<CA+hUKG+mUfH81RuYm5fJrOxdm85hvxLEm=KxXm+n-12FJJH9jA@mail.gmail.com>
	<CAOYmi+nk-KHGGBHz6BGik4+xHPmyPrwOj3ezSM3F4d=-kH_n2Q@mail.gmail.com>
	<CAOYmi+n4EDOOUL27_OqYT2-F2rS6S+3mK-ppWb2Ec92UEoUbYA@mail.gmail.com>
	<CAOYmi+nGstyp4OyL8SFCm3dtkBzNJqGwL7xYhe85=j2hhaXAMw@mail.gmail.com>
	<32e5741d-3dc8-4b15-8c56-cfb26483563c@tantorlabs.com>
	<CAOYmi+mRmRHD-fhXErR0kNqL5NMebPw1EEx++mgmrMAwLszCyw@mail.gmail.com>
	<8a611028-51a1-408c-b592-832e2e6e1fc9@tantorlab! s.com>
	<CAOYmi+=ORLb7mYdLRyrBE5ZGKd74HC4akLF-Vky-yPZCH38=yQ@mail.gmail.com>

Jacob Champion <jacob.champion@enterprisedb.com> writes:
> On Wed, Jul 2, 2025 at 5:45 AM Ivan Kush <ivan.kush@tantorlabs.com> wrote:
>> Why don't we set LIBS in the configure in "checking for curl_multi_init"
>> using LIBCURL_LIBS or LIBCURL_LDFLAGS?
>> [...]
>> Without these LIBCURL... variables we will check a system libcurl, not
>> our local.

> Ah, that's definitely a bug.

I just ran into a vaguely-related failure: on RHEL8, building
with --with-libcurl leads to failures during check-world:

../../../../src/interfaces/libpq/libpq.so: undefined reference to `dlopen'
../../../../src/interfaces/libpq/libpq.so: undefined reference to `dlclose'
../../../../src/interfaces/libpq/libpq.so: undefined reference to `dlerror'
../../../../src/interfaces/libpq/libpq.so: undefined reference to `dlsym'
collect2: error: ld returned 1 exit status

Per "man dlopen", you have to link with libdl to use these functions
on this platform.  (Curiously, although RHEL9 still says that in the
documentation, it doesn't seem to actually need -ldl.)  I was able
to resolve this by adding -ldl in libpq's Makefile:

-SHLIB_LINK += $(filter -lcrypt -ldes -lcom_err -lcrypto -lk5crypto -lkrb5 -lgssapi_krb5 -lgss -lgssapi -lssl -lsocket -lnsl -lresolv -lintl -lm, $(LIBS)) $(LDAP_LIBS_FE) $(PTHREAD_LIBS)
+SHLIB_LINK += $(filter -lcrypt -ldes -lcom_err -lcrypto -lk5crypto -lkrb5 -lgssapi_krb5 -lgss -lgssapi -lssl -lsocket -lnsl -lresolv -lintl -ldl -lm, $(LIBS)) $(LDAP_LIBS_FE) $(PTHREAD_LIBS)

It doesn't look like the Meson support needs such explicit tracking of
required libraries, but perhaps I'm missing something?  I'm not able
to test that directly for lack of a usable ninja version on this
platform.

Apologies for not noticing this sooner.  I don't think I'd tried
--with-libcurl since the changes to split out libpq-oauth.

			regards, tom lane





view thread (424+ messages)  latest in thread

Message-ID: <1328170.1752082586@sss.pgh.pa.us>
Permalink:  ../1328170.1752082586@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1328170.1752082586@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, jacob.champion@enterprisedb.com, ivan.kush@tantorlabs.com, lev.nikolaev@tantorlabs.com
  Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER
  In-Reply-To: <1328170.1752082586@sss.pgh.pa.us>
  References: <83C44AB4-24B0-437F-B139-B5CBC5821BB1@yesql.se> <CAOYmi+mf+hw7x+E3XkRypEGy=yR3n6zowjjXeXaSK20WxX3UGw@mail.gmail.com> <CAOYmi+kr-Eh7utEDZBFq8Mc9byLLRF3ZNc0TaHt78SKwB4T5KA@mail.gmail.com> <CA+hUKGL3yYmKmNHw1wnpuhCbqaiDw1DDUhghEDrh6y97Ygzw9Q@mail.gmail.com> <CAOYmi+kOyST1DoF1WOMQvf75L56LiLHZR2+3qTJ+QCg2KC8raQ@mail.gmail.com> <CA+hUKGL59uY=UpCHEmTL6dpzuWJBVf1Kc4bQADYDEWG9ZDCffA@mail.gmail.com> <CAOYmi+k6HUMK4XQAfnxsmgs1oPOKnchyj2O2a+R7H9jOTU4LPQ@mail.gmail.com> <CA+hUKG+mUfH81RuYm5fJrOxdm85hvxLEm=KxXm+n-12FJJH9jA@mail.gmail.com> <CAOYmi+nk-KHGGBHz6BGik4+xHPmyPrwOj3ezSM3F4d=-kH_n2Q@mail.gmail.com> <CAOYmi+n4EDOOUL27_OqYT2-F2rS6S+3mK-ppWb2Ec92UEoUbYA@mail.gmail.com> <CAOYmi+nGstyp4OyL8SFCm3dtkBzNJqGwL7xYhe85=j2hhaXAMw@mail.gmail.com> <32e5741d-3dc8-4b15-8c56-cfb26483563c@tantorlabs.com> <CAOYmi+mRmRHD-fhXErR0kNqL5NMebPw1EEx++mgmrMAwLszCyw@mail.gmail.com> <CAOYmi+=ORLb7mYdLRyrBE5ZGKd74HC4akLF-Vky-yPZCH38=yQ@mail.gmail.com> <1328170.1752082586@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox