From: Antonin Houska <ah@cybertec.at>
To: pgsql-hackers@postgresql.org
Subject: Misplaced comment in snapbuild.c
Date: Wed, 09 Sep 2026 20:35:51 +0200
Message-ID: <14864.1788978951@localhost> (raw)
This patch moves a comment to where it was until commits 2bef06d516 and
240e0dbacd added some code (including another comment) in front of the related
line.
--
Antonin Houska
Web: https://www.cybertec-postgresql.comAttachments:
[text/x-diff] move_comment_to_original_location.diff (1.1K, ../14864.1788978951@localhost/2-move_comment_to_original_location.diff)
download | inline diff:diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.cindex f60bcf09605..de491ea0c4b 100644--- a/src/backend/replication/logical/snapbuild.c+++ b/src/backend/replication/logical/snapbuild.c@@ -471,10 +471,6 @@ SnapBuildInitialSnapshot(SnapBuild *builder)
snap = SnapBuildBuildSnapshot(builder);
/*
- * We know that snap->xmin is alive, enforced by the logical xmin- * mechanism. Due to that we can do this without locks, we're only- * changing our own value.- *
* Building an initial snapshot is expensive and an unenforced xmin
* horizon would have bad consequences, therefore always double-check that
* the horizon is enforced.
@@ -487,6 +483,11 @@ SnapBuildInitialSnapshot(SnapBuild *builder)
elog(ERROR, "cannot build an initial slot snapshot as oldest safe xid %u follows snapshot's xmin %u",
safeXid, snap->xmin);
+ /*+ * We know that snap->xmin is alive, enforced by the logical xmin+ * mechanism. Due to that we can do this without locks, we're only+ * changing our own value.+ */
MyProc->xmin = snap->xmin;
/* allocate in transaction context */
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ah@cybertec.at
Subject: Re: Misplaced comment in snapbuild.c
In-Reply-To: <14864.1788978951@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox