From: legrand legrand <legrand_legrand@hotmail.com>
To: pgsql-bugs@postgresql.org
Subject: pg_stat_statements: rows not updated for CREATE TABLE AS SELECT statements
Date: Sun, 15 Mar 2020 10:35:55 -0700 (MST)
Message-ID: <1584293755198-0.post@n3.nabble.com> (raw)
Hello,
it seems that column "rows" is not updated after CREATE TABLE AS SELECT
statements.
pg13devel (snapshot 2020-03-14)
postgres=# select name,setting from pg_settings where name like 'pg_stat%';
name | setting
----------------------------------+---------
pg_stat_statements.max | 5000
pg_stat_statements.save | on
pg_stat_statements.track | all
pg_stat_statements.track_utility | on
(4 rows)
postgres=# select pg_stat_statements_reset();
pg_stat_statements_reset
--------------------------
(1 row)
postgres=# create table ctas as select * from pg_class;
SELECT 386
postgres=# select query,calls,rows from pg_stat_statements where query like
'create table ctas%';
query | calls | rows
---------------------------------------------+-------+------
create table ctas as select * from pg_class | 1 | 0
(1 row)
after modifying the following line in pg_stat_statements.c
rows = (qc && qc->commandTag == CMDTAG_COPY) ? qc->nprocessed : 0;
into
rows = (qc && (qc->commandTag == CMDTAG_COPY
|| qc->commandTag == CMDTAG_SELECT)
) ? qc->nprocessed : 0;
column rows seems properly updated.
What do you think about that fix ?
Thanks in advance
Regards
PAscal
--
Sent from: https://www.postgresql-archive.org/PostgreSQL-bugs-f2117394.html
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: legrand_legrand@hotmail.com
Subject: Re: pg_stat_statements: rows not updated for CREATE TABLE AS SELECT statements
In-Reply-To: <1584293755198-0.post@n3.nabble.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox