pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feed From: Tom Lane <tgl@sss.pgh.pa.us>
To: Joseph Koshakow <koshy44@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Fix overflow in DecodeInterval
Date: Sun, 03 Apr 2022 03:09:07 -0400
Message-ID: <1592893.1648969747@sss.pgh.pa.us> (raw )
In-Reply-To: <1531188.1648930455@sss.pgh.pa.us >
References: <CAAvxfHff0JLYHwyBrtMx_=6wr=k2Xp+D+-X3vEhHjJYMj+mQcg@mail.gmail.com >
<2176379.1644612942@sss.pgh.pa.us >
<CAAvxfHd-DZzRC9wROFbsZq=8zK+R-5G7DAoZ-oUK8n09cGA0eA@mail.gmail.com >
<CAAvxfHddHqA=dDKrbi+d+vo52j=sUwVt6_PYOsJGo+Eq91v4=g@mail.gmail.com >
<20220213035150.wusl6mmbeb3m3jpy@alap3.anarazel.de >
<CAAvxfHdrQc8pVoSnTPBfTKzHQzmYTg1qheNxMLoWDcrWpTJapg@mail.gmail.com >
<20220213203037.ie7bgjrodupzxhda@alap3.anarazel.de >
<2726280.1644784719@sss.pgh.pa.us >
<CAAvxfHd3gsOkGsbu5AVG+ayHiqsWzuZsi8WknL7v4C_A_4TwOQ@mail.gmail.com >
<CAAvxfHeNNjsJarnzVOycP__T2x4iwbbSWBDaDePcuBjz8--x6Q@mail.gmail.com >
<20220215162809.yryv7bj24lxfoo37@alap3.anarazel.de >
<CAAvxfHfKYHw8n19s7eAcDo_B2T1SS22O1p0X4OE5_WBK230O+Q@mail.gmail.com >
<CAAvxfHduBhZdUXLFwLOSGW=0c17frLojcbCqNsZrw5n73pekZg@mail.gmail.com >
<CAAvxfHdVaHrriTWyvsLg3POX13rOyUGysur59sOT02qmmTq0Rg@mail.gmail.com >
<410974.1645400227@sss.pgh.pa.us >
<CAAvxfHdQGiX2xC78y3Y_LTdCiTOWtMXkaLai7s7-mG+=H7qNXA@mail.gmail.com >
<1344498.1648920056@sss.pgh! ! .pa.us >
<CAAvxfHdC-A3-F31xHiE06oiFgNFM5qrkK0TD9WH0ZKCMFJ=B+w@mail.gmail.com >
<CAAvxfHd730o24gGhu5YoL1Sxt0B=KfoL5aq5uttufjqLEiKitA@mail.gmail.com >
<CAAvxfHdM_8rhBP+GLj_9rSHswjBESztrxEV+GrTvXv9fAnBUfQ@mail.gmail.com >
<CAAvxfHecFFqpn=5H0T3N1Bki=rkgW0BmRNOZ1NZdKDMCOoy+Rw@mail.gmail.com >
<1523458.1648926618@sss.pgh.pa.us >
<CAAvxfHf8mXDaCjHmvDHNcKw8o8+cBOHiB+nE5ea9_a-1oiVS0Q@mail.gmail.com >
<1531188.1648930455@sss.pgh.pa.us >
I wrote:
> Cool. I've pushed the patch.
Hmm ... buildfarm's not entirely happy [1][2][3]:
inline patch 1: /home/nm/farm/gcc64/HEAD/pgsql.build/src/test/regress/results/interval.out (+1/-1 lines) download inline-1.patch diff -U3 /home/nm/farm/gcc64/HEAD/pgsql.build/src/test/regress/expected/interval.out /home/nm/farm/gcc64/HEAD/pgsql.build/src/test/regress/results/interval.out
--- /home/nm/farm/gcc64/HEAD/pgsql.build/src/test/regress/expected/interval.out 2022-04-03 04:56:32.000000000 +0000
+++ /home/nm/farm/gcc64/HEAD/pgsql.build/src/test/regress/results/interval.out 2022-04-03 05:23:00.000000000 +0000
@@ -1465,7 +1465,7 @@
LINE 1: select interval 'PT2562047788.1:00:54.775807';
^
select interval 'PT2562047788:01.:54.775807';
- ERROR: interval field value out of range: "PT2562047788:01.:54.775807"
+ ERROR: invalid input syntax for type interval: "PT2562047788:01.:54.775807"
LINE 1: select interval 'PT2562047788:01.:54.775807';
^
-- overflowing with fractional fields - SQL standard format
What do you make of that? I'm betting that strtod() works a
bit differently on those old platforms, but too tired to
look closer tonight.
regards, tom lane
[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sungazer&dt=2022-04-03%2004%3A56%3A34
[2] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hoverfly&dt=2022-04-03%2000%3A51%3A50
[3] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2022-04-03%2000%3A32%3A10
view thread (42+ messages) latest in thread
Message-ID: <1592893.1648969747@sss.pgh.pa.us>
Permalink: ../1592893.1648969747@sss.pgh.pa.us/
Also on: postgresql.org/message-id/1592893.1648969747@sss.pgh.pa.us
copy link · copy postgr.es · copy git am
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, koshy44@gmail.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: Fix overflow in DecodeInterval
In-Reply-To: <1592893.1648969747@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox