pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: JSONPATH documentation
Date: Sun, 22 Sep 2019 18:03:32 -0400
Message-ID: <16968.1569189812@sss.pgh.pa.us> (raw)
In-Reply-To: <CAPpHfdvYektyqQp-On+dbqO7GV_h=59y=6yGxUm4Pisc2PcDjg@mail.gmail.com>
References: <CAMkU=1wP-SO4KpiLxHJuPezTJCmK=JqefLXrr3eXFO7Qku+tMg@mail.gmail.com>
	<CAPpHfdvYektyqQp-On+dbqO7GV_h=59y=6yGxUm4Pisc2PcDjg@mail.gmail.com>

Alexander Korotkov <a.korotkov@postgrespro.ru> writes:
> On Sun, Sep 22, 2019 at 9:18 PM Jeff Janes <jeff.janes@gmail.com> wrote:
> Currently description of jsonpath is divided between datatypes section
> and functions and operators section.  And yes, this looks cumbersome.

Agreed, but ...

> I think we should move the whole description to the one section.
> Probably we should move jsonpath description to datatypes section
> (assuming jsonpath is a datatype) leaving functions and operators
> section with just SQL-level functions and operators.  What do you
> think?

... I don't think that's an improvement.  We don't document detailed
behavior of a datatype's functions in datatype.sgml, and this seems
like it would be contrary to that layout.  If anything, I'd merge
the other way, with only a very minimal description of jsonpath
(perhaps none?) in datatype.sgml.

While we're whining about this, I find it very off-putting that
the jsonpath stuff was inserted in the JSON functions section
ahead of the actual JSON functions.  I think it should have
gone after them, because it feels like a barely-related interjection
as it stands.  Maybe there's even a case that it should be
its own <sect1>, after the "functions-json" section.

			regards, tom lane





view thread (13+ messages)  latest in thread

Message-ID: <16968.1569189812@sss.pgh.pa.us>
Permalink:  ../16968.1569189812@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/16968.1569189812@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, a.korotkov@postgrespro.ru, jeff.janes@gmail.com
  Subject: Re: JSONPATH documentation
  In-Reply-To: <16968.1569189812@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox