pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: PG Bug reporting form <noreply@postgresql.org>
To: pgsql-bugs@lists.postgresql.org
Cc: robert.sosinski@reactive.io
Subject: BUG #17045: 14 Beta Tighten up allowed names for custom GUC parameters breaks PostgREST
Date: Wed, 02 Jun 2021 19:34:59 +0000
Message-ID: <17045-6a4a9f0d1513f72b@postgresql.org> (raw)

The following bug has been logged on the website:

Bug reference:      17045
Logged by:          Robert Sosinski
Email address:      robert.sosinski@reactive.io
PostgreSQL version: 14beta1
Operating system:   All
Description:        

Recently (April 7th 2020) a new change was made to the PostgreSQL 14 beta
that changes allowed names for custom GUC keys. Please see the following:

1. The code change:
https://github.com/postgres/postgres/commit/3db826bd55cd1df0dd8c3d811f8e5b936d7ba1e4
2. Initial question about valid GUC keys:
https://www.postgresql.org/message-id/flat/20210209144059.GA21360%40depesz.com
3. More conversation about what valid GUC keys should be:
https://www.postgresql-archive.org/Tightening-up-allowed-custom-GUC-names-td6178392.html

This change allows there to only be one `.` in the GUC key.  The problem is
that PostgreSQL uses multiple `.` in GUC keys to nest parameters, such as
`request.jwt.claim.role`.  As such this would be a change that significantly
breaks PostgREST.

You can see the conversation at PostgREST here:
https://github.com/PostgREST/postgrest/issues/1857

It seems this change was mainly targeting special characters such as `-` and
`=`, could this be updated to allow multiple `.` characters for GUC keys as
well? There does not seem there is any issues with multiple `.` characters
in GUC keys.

Thanks!



view thread (4+ messages)  latest in thread

Message-ID: <17045-6a4a9f0d1513f72b@postgresql.org>
Permalink:  ../17045-6a4a9f0d1513f72b@postgresql.org/
Also on:    postgresql.org/message-id/17045-6a4a9f0d1513f72b@postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: noreply@postgresql.org, pgsql-bugs@lists.postgresql.org, robert.sosinski@reactive.io
  Subject: Re: BUG #17045: 14 Beta Tighten up allowed names for custom GUC parameters breaks PostgREST
  In-Reply-To: <17045-6a4a9f0d1513f72b@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox