pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alexander Lakhin <exclusion@gmail.com>
To: Antonin Houska <ah@cybertec.at>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Cc: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Cc: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
Date: Sun, 12 Apr 2026 17:00:00 +0300
Message-ID: <18181295-8375-4789-ad32-269d78d6001e@gmail.com> (raw)
In-Reply-To: <121156.1775818667@localhost>
References: <202604072027.gazfa2zt2l2j@alvherre.pgsql>
	<a38fc771-c860-4605-8c44-d16e8aff2534@gmail.com>
	<121156.1775818667@localhost>

Hello Antonin and Alvaro,

10.04.2026 13:57, Antonin Houska wrote:
> Attached is a fix that works for me.
>
> Nevertheless, REPACK (CONCURRENTLY) in your test goes ahead only due to commit
> 0d3dba38c7, which will probably be reverted [1]. Then REPACK will wait for the
> transaction in the other database (db1) to complete before it can actually
> start.

Thank you for the fix!

I've stumbled upon one more issue with this feature:
CREATE TABLE t (i int PRIMARY KEY);
REPACK (CONCURRENTLY) t;

fails for me with sanitizers enabled and
min_dynamic_shared_memory = '1GB'
in postgresql.conf as below:
2026-04-12 13:23:02.000 UTC [2733633] LOG:  statement: REPACK (CONCURRENTLY) t;
repack.c:3373:15: runtime error: load of value 240, which is not a valid value for type '_Bool'
     #0 0x6441f7eba454 in start_repack_decoding_worker .../src/backend/commands/repack.c:3373
     #1 0x6441f7ebdaad in rebuild_relation .../src/backend/commands/repack.c:1010
     #2 0x6441f7ebe9a2 in cluster_rel .../src/backend/commands/repack.c:656
     #3 0x6441f7ebefea in process_single_relation .../src/backend/commands/repack.c:2359
     #4 0x6441f7ebf870 in ExecRepack .../src/backend/commands/repack.c:296
     #5 0x6441f886f20e in standard_ProcessUtility .../src/backend/tcop/utility.c:867
...

2026-04-12 13:23:03.620 UTC [2733620] LOG:  client backend (PID 2733633) was terminated by signal 6: Aborted
2026-04-12 13:23:03.620 UTC [2733620] DETAIL:  Failed process was running: REPACK (CONCURRENTLY) t;

Could you please have a look?

Best regards,
Alexander

view thread (415+ messages)  latest in thread

Message-ID: <18181295-8375-4789-ad32-269d78d6001e@gmail.com>
Permalink:  ../18181295-8375-4789-ad32-269d78d6001e@gmail.com/
Also on:    postgresql.org/message-id/18181295-8375-4789-ad32-269d78d6001e@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: exclusion@gmail.com, ah@cybertec.at, alvherre@alvh.no-ip.org, amit.kapila16@gmail.com, kuroda.hayato@fujitsu.com, srinath2133@gmail.com, mihailnikalayeu@gmail.com, boekewurm+postgres@gmail.com, pgsql-hackers@lists.postgresql.org, rob@xzilla.net
  Subject: Re: Adding REPACK [concurrently]
  In-Reply-To: <18181295-8375-4789-ad32-269d78d6001e@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox