pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feed From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Yuzuko Hosoya <hosoya.yuzuko@lab.ntt.co.jp>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Runtime pruning problem
Date: Wed, 11 Dec 2019 19:14:50 -0500
Message-ID: <18891.1576109690@sss.pgh.pa.us> (raw )
In-Reply-To: <24902.1575587869@sss.pgh.pa.us >
References: <001001d4f44b$2a2cca50$7e865ef0$@lab.ntt.co.jp >
<CAKJS1f_4b9J7K7DSuZMkyga67OetfyAWz1xzYJd25HSf9-cijQ@mail.gmail.com >
<b50238ec-e402-6fcb-7f3a-b74418471b29@lab.ntt.co.jp >
<CAKJS1f98o-6-SWWzcfiJO6JAQFu2DnYWBzFVB0x2+u5ub=ASEA@mail.gmail.com >
<c4acce90-8265-c91f-065f-e4507ad054bd@lab.ntt.co.jp >
<2018.1555473241@sss.pgh.pa.us >
<CAKJS1f9ch8rVy8ZhsV2J7q0zCq4xFuXWxTT90EadpkTsgCvQQw@mail.gmail.com >
<2923.1555474214@sss.pgh.pa.us >
<f1ad1911-df47-b555-8df5-825e3a8aa69c@lab.ntt.co.jp >
<17368.1555608352@sss.pgh.pa.us >
<CAKJS1f_020O9bX-c1cGcDM2L5DU44hRQ3k_0MXBBqKxAQ=X5bg@mail.gmail.com >
<CAKJS1f_GZ6LtonDHBJ0pgwtT+OFWmJBap60Fb9iQ++it4aXCFA@mail.gmail.com >
<CAKJS1f_mw47rnotO4VvpmH42cVKAPn0bkTCzevugGPqeQrW6uQ@mail.gmail.com >
<CAKJS1f82v4fEtH-XkGfUq-QEDErYBvkH8BkmchAT53vUjD+g7Q@mail.gmail.com >
<6779.1564525639@sss.pgh.pa.us >
<CAKJS1f8NDUNRY=YEMj1-qkyGvJi4AOL7v7LsGNx1spZQf-P7mA@mail.gmail.com >
<7814.1564527032@sss.pgh.pa.us >
<8056.1564527407@sss.pgh.pa.us >
<19442.1575473401@sss.pgh! ! .pa.us >
<24902.1575587869@sss.pgh.pa.us >
I wrote:
> OK, so here's a finished set of patches for this issue.
> 0001 is the same patch I posted on Tuesday; I kept it separate just
> because it seemed like a largely separable set of changes. (Note that
> the undesirable regression test output changes are undone by 0002.)
> 0002 implements the map-vars-back-to-the-inheritance parent change
> per my sketch. Notice that relation aliases and Var names change
> underneath Appends/MergeAppends, but Vars above one are (mostly)
> printed the same as before. On the whole I think this is a good
> set of test output changes, reflecting a more predictable approach
> to assigning aliases to inheritance children. But somebody else
> might see it differently I suppose.
> Finally, 0003 is the remaining portion of David's patch to allow
> deletion of all of an Append/MergeAppend's sub-plans during
> executor startup pruning.
I pushed these, and the buildfarm immediately got a bad case of
the measles. All the members using force_parallel_mode = regress
fail on the new regression test case added by 0003, with diffs
like this:
diff -U3 /home/pgbf/buildroot/HEAD/pgsql.build/src/test/regress/expected/partition_prune.out /home/pgbf/buildroot/HEAD/pgsql.build/src/test/regress/results/partition_prune.out
--- /home/pgbf/buildroot/HEAD/pgsql.build/src/test/regress/expected/partition_prune.out Thu Dec 12 00:40:04 2019
+++ /home/pgbf/buildroot/HEAD/pgsql.build/src/test/regress/results/partition_prune.out Thu Dec 12 00:45:44 2019
@@ -3169,10 +3169,12 @@
--------------------------------------------
Limit (actual rows=0 loops=1)
Output: ma_test.a, ma_test.b
+ Worker 0: actual rows=0 loops=1
-> Merge Append (actual rows=0 loops=1)
Sort Key: ma_test.b
+ Worker 0: actual rows=0 loops=1
Subplans Removed: 3
-(5 rows)
+(7 rows)
deallocate mt_q2;
reset plan_cache_mode;
This looks to me like there's some other part of EXPLAIN that
needs to be updated for the possibility of zero child nodes, but
I didn't find out just where in a few minutes of searching.
As a stopgap to get back to green buildfarm, I removed this
specific test case, but we need to look at it closer.
regards, tom lane
view thread (38+ messages)
Message-ID: <18891.1576109690@sss.pgh.pa.us>
Permalink: ../18891.1576109690@sss.pgh.pa.us/
Also on: postgresql.org/message-id/18891.1576109690@sss.pgh.pa.us
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, david.rowley@2ndquadrant.com, Langote_Amit_f8@lab.ntt.co.jp, hosoya.yuzuko@lab.ntt.co.jp, pgsql-hackers@lists.postgresql.org
Subject: Re: Runtime pruning problem
In-Reply-To: <18891.1576109690@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox