pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Jesper Pedersen <jesper.pedersen@redhat.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Oskari Saarenmaa <os@ohmu.fi>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Tobias Oberstein <tobias.oberstein@gmail.com>
Subject: Re: pread() and pwrite()
Date: Mon, 08 Oct 2018 21:55:34 -0400
Message-ID: <19344.1539050134@sss.pgh.pa.us> (raw)
In-Reply-To: <CAEepm=15aoFSr9G25T4wP_6vTKd1bPAViu5pZtrObyviMvowpQ@mail.gmail.com>
References: <CAEepm=02rapCpPR3ZGF2vW=SBHSdFYO_bz_f-wwWJonmA3APgw@mail.gmail.com>
	<20180720081459.GC22214@saarenmaa.fi>
	<CAEepm=2qRXWM+uX26dPn6S=TAqi8FfuAZ9vG8tZW9Jo7w6YeQw@mail.gmail.com>
	<7f379440-dfec-70ca-8a0d-942f1381936b@redhat.com>
	<c2f56d0a-cadd-3df1-ae48-b84dc8128c37@redhat.com>
	<CAEepm=1DZSzdBRDbXFXSiu_Hiv08f22kFmgCi7ZBRERF_=ZCPg@mail.gmail.com>
	<983a8d48-64fa-e2f7-55c4-41e20bc51ef5@redhat.com>
	<CAEepm=15aoFSr9G25T4wP_6vTKd1bPAViu5pZtrObyviMvowpQ@mail.gmail.com>

Thomas Munro <thomas.munro@enterprisedb.com> writes:
> Rebased again.  Patches that touch AC_CHECK_FUNCS are fun like that!

Yeah, I've been burnt by that too recently.  It occurs to me we could make
that at least a little less painful if we formatted the macro with one
line per function name:

AC_CHECK_FUNCS([
	cbrt
	clock_gettime
	fdatasync
	...
	wcstombs_l
])

You'd still get conflicts in configure itself, of course, but that
doesn't require manual work to resolve -- just re-run autoconf.

			regards, tom lane




view thread (41+ messages)  latest in thread

Message-ID: <19344.1539050134@sss.pgh.pa.us>
Permalink:  ../19344.1539050134@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/19344.1539050134@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, thomas.munro@enterprisedb.com, jesper.pedersen@redhat.com, magnus@hagander.net, os@ohmu.fi, tobias.oberstein@gmail.com
  Subject: Re: pread() and pwrite()
  In-Reply-To: <19344.1539050134@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox