pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: PG Bug reporting form <noreply@postgresql.org>
To: pgsql-bugs@lists.postgresql.org
Cc: alpkeles99@gmail.com
Subject: BUG #19783: Sorted GROUPING SETS return a grouping column's value in a set that leaves it out
Date: Wed, 21 Oct 2026 19:59:51 +0000
Message-ID: <19783-070e4bf0c73c1076@postgresql.org> (raw)

The following bug has been logged on the website:

Bug reference:      19783
Logged by:          Alperen Keles
Email address:      alpkeles99@gmail.com
PostgreSQL version: 19rc1
Operating system:   macOS 26 arm64
Description:        

Hello,

With a sorted grouping-sets plan (GroupAggregate), a column that is not
in the current grouping set can show its real value instead of NULL,
while GROUPING() for the same row says it is not grouped. It happens
when the row has a NULL somewhere and the target list reads a column
that comes after the grouping columns in the Agg's input:

  CREATE TABLE t (id int PRIMARY KEY, a int, b int, c int);
  INSERT INTO t VALUES (1, 10, NULL, 100);
  SET enable_hashagg = off;
  SELECT a, b, c, GROUPING(a, b) AS g
    FROM t GROUP BY GROUPING SETS ((id, a), (id, b));

   a  | b |  c  | g
  ----+---+-----+---
   10 |   | 100 | 1
   10 |   | 100 | 2
  (2 rows)

The second row belongs to the set (id, b), so a should be NULL there
(g = 2 says so). 18.6 and 14.24, and master with enable_hashagg = on,
give

   a  | b |  c  | g
  ----+---+-----+---
   10 |   | 100 | 1
      |   | 100 | 2

With b = 20 instead of NULL, or without c in the select list, the
result is right. The plan is

  GroupAggregate
    Output: a, b, c, GROUPING(a, b), id
    Group Key: t.id, t.a
    Sort Key: t.id, t.b
      Group Key: t.id, t.b
    ->  Sort
          Output: a, b, id, c
          Sort Key: t.id, t.a

Reproduced on master dd568b047ac (2026-10-21) and 158b6d5109f,
macOS arm64, and on master a261fc2b722 and 19rc1 (REL_19_STABLE
1212d5d33b1), Ubuntu 24.04 x86_64, all --enable-cassert. Not on 18.6
(REL_18_STABLE a85b5523e67 on macOS, dfbc1507cdb on Ubuntu) or 14.24
(REL_14_STABLE 14904052e65, Ubuntu).

As far as I can tell, prepare_projection_slot() in nodeAgg.c deforms
the input slot up to the last grouping column and then sets
tts_isnull[] to true for the grouping columns not in the current set.
Projecting c then deforms the slot further. Since c456e391138
("Optimize tuple deformation"), slot_deform_heap_tuple() calls
populate_isnull_array() from attribute 0 whenever the tuple has a null
bitmap, so tts_isnull[] for the columns already deformed is rewritten
from the bitmap, and a's forced NULL is lost. The value in
tts_values[] is still a's. This looks like the same overwrite as in
the "Whole row var issue" thread, fixed for missing attributes in
d260d7d003f; master with that commit still gives the result above.

Found with a query fuzzer.

Regards,
Alperen Keles








view thread (6+ messages)  latest in thread

Message-ID: <19783-070e4bf0c73c1076@postgresql.org>
Permalink:  ../19783-070e4bf0c73c1076@postgresql.org/
Also on:    postgresql.org/message-id/19783-070e4bf0c73c1076@postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: noreply@postgresql.org, alpkeles99@gmail.com
  Subject: Re: BUG #19783: Sorted GROUPING SETS return a grouping column's value in a set that leaves it out
  In-Reply-To: <19783-070e4bf0c73c1076@postgresql.org>
  References: <19783-070e4bf0c73c1076@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox