From: David Steele <david@pgmasters.net>
To: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date: Thu, 5 Mar 2020 12:51:50 -0500
Message-ID: <1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net> (raw)
In-Reply-To: <E1j9ioh-0005Kn-4O@gemulon.postgresql.org>
References: <E1j9ioh-0005Kn-4O@gemulon.postgresql.org>
Hi Michael,
On 3/5/20 12:13 AM, Michael Paquier wrote:
> Avoid -Wconversion warnings when using checksum_impl.h
>
> This does not matter much when compiling Postgres proper as many
> warnings exist when enabling this compilation flag, but it can be
> annoying for external modules willing to use both.
Looks like you changed 65535 -> 65536 before commit. I checked the
original patch and it has 65535.
Bit of a bummer that this passed make check-world, but the pgBackRest
tests definitely did not like it.
Thanks,
--
-David
david@pgmasters.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: david@pgmasters.net, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
In-Reply-To: <1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox