[Jonathan S. Katz <jkatz@postgresql.org>]

On 9/27/18 9:21 PM, Amit Langote wrote:
> On 2018/09/27 23:24, Alvaro Herrera wrote:
>> On 2018-Sep-27, Amit Langote wrote:
>>
>>> Sorry I couldn't reply sooner, but the following of your proposed text
>>> needs to be updated a bit:
>>>
>>> +       <listitem>
>>> +        <para>
>>> +         Having a "default" partition for storing data that does not match a
>>> +         partition key
>>> +        </para>
>>> +       </listitem>
>>>
>>> I think "does not match a partition key" is not accurate.  Description of
>>> default partitions further below in the release notes says this:
>>>
>>> "The default partition can store rows that don't match any of the other
>>> defined partitions, and is searched accordingly."
>>>
>>> So, we could perhaps write it as:
>>>
>>> Having a "default" partition for storing data that does not match any of
>>> the remaining partitions
>>
>> Yeah, I agree that "a partition key" is not the right term to use there
>> (and that term is used in the press release text also).  However I don't
>> think "remaining" is the right word there either, because it sounds as
>> if you're removing something.
>>
>> For the Spanish translation of the press release, we ended up using the
>> equivalent of "for the data that does not match any other partition".
> 
> Yeah, "any other partition" is what the existing description uses too, so:
> 
> Having a "default" partition for storing data that does not match any
> other partition

Sorry for the slow turnaround on this. Excellent suggestion. I have
updated the patches, please see attached.

Thanks,

Jonathan

Attachments: download all (3 files, .tar.gz)

0001-Updates-to-major-improvements-section-of-release-not.patch (text/plain, 3.5K) download
From 6fee4bd74a3ce32b47a9b53ad9d5536d069b6f56 Mon Sep 17 00:00:00 2001
From: "Jonathan S. Katz" <jonathan.katz@excoventures.com>
Date: Sat, 15 Sep 2018 10:43:44 -0400
Subject: [PATCH 1/2] Updates to major improvements section of release notes.

---
 doc/src/sgml/release-11.sgml | 41 +++++++++++++++++++++++++++++------------
 1 file changed, 29 insertions(+), 12 deletions(-)

diff --git a/doc/src/sgml/release-11.sgml b/doc/src/sgml/release-11.sgml
index ae65431bbe..f9d93b734e 100644
--- a/doc/src/sgml/release-11.sgml
+++ b/doc/src/sgml/release-11.sgml
@@ -6,7 +6,7 @@
 
   <formalpara>
    <title>Release date:</title>
-   <para>2018-??-?? (CURRENT AS OF 2018-07-30)</para>
+   <para>2018-10-?? (CURRENT AS OF 2018-09-20)</para>
   </formalpara>
 
   <sect2>
@@ -22,7 +22,7 @@
 
     <listitem>
      <para>
-      Major improvements to partitioning:
+      Improvements to partitioning functionality, including:
       <itemizedlist>
        <listitem>
         <para>
@@ -37,9 +37,8 @@
        </listitem>
        <listitem>
         <para>
-         Improved <command>SELECT</command> query performance due to
-         enhanced partition elimination during query processing and
-         execution
+         Improved <command>SELECT</command> performance from enhanced partition
+         elimination strategies during query processing and execution
         </para>
        </listitem>
        <listitem>
@@ -48,29 +47,37 @@
          KEY</literal>, indexes, and triggers on partitioned tables
         </para>
        </listitem>
+       <listitem>
+        <para>
+         Having a "default" partition for storing data that does not match any
+         of the remaining partitions
+        </para>
+       </listitem>
       </itemizedlist>
      </para>
     </listitem>
 
     <listitem>
      <para>
-      Improvements to parallelism:
+      Improvements to parallelism, including:
       <itemizedlist>
        <listitem>
         <para>
-         Parallelized hash joins
+         B-tree indexes can now be built in parallel with
+         <command>CREATE INDEX</command>
         </para>
        </listitem>
        <listitem>
         <para>
-         Parallelized <command>CREATE INDEX</command> for B-tree indexes
+         Parallelized <command>CREATE TABLE .. AS</command>,
+         <command>CREATE MATERIALIZED VIEW</command>, and certain
+         queries using <literal>UNION</literal>
         </para>
        </listitem>
        <listitem>
         <para>
-         Parallelized <command>CREATE TABLE .. AS</command>,
-         <command>CREATE MATERIALIZED VIEW</command>, and certain
-         queries using <literal>UNION</literal>
+         Performance improvements for parallelized hash joins and parallelized
+         sequential scans
         </para>
        </listitem>
       </itemizedlist>
@@ -79,7 +86,10 @@
 
     <listitem>
      <para>
-      SQL stored procedures, with support for embedded transactions
+      SQL stored procedures that support embedded transactions. Stored
+      procedures can be created with <link linkend="sql-createprocedure">
+      <command>CREATE PROCEDURE</command></link> and executed with
+      <link linkend="sql-call"><command>CALL</command></link>
      </para>
     </listitem>
 
@@ -99,6 +109,13 @@
      </para>
     </listitem>
 
+    <listitem>
+     <para>
+      Covering indexes, which can be utilized using the
+      <literal>INCLUDE</literal> clause of <command>CREATE INDEX</command>
+     </para>
+    </listitem>
+
     <listitem>
      <para>
       Many other useful performance improvements, including making
-- 
2.14.3 (Apple Git-98)



0002-Remove-or-modify-placeholders-for-v11-release-notes.patch (text/plain, 2.4K) download
From a1922a4a590655ac9544fd41460a998fd975523b Mon Sep 17 00:00:00 2001
From: "Jonathan S. Katz" <jonathan.katz@excoventures.com>
Date: Sat, 15 Sep 2018 11:01:35 -0400
Subject: [PATCH 2/2] Remove or modify placeholders for v11 release notes.

---
 doc/src/sgml/release-11.sgml | 18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/doc/src/sgml/release-11.sgml b/doc/src/sgml/release-11.sgml
index f9d93b734e..ca42f28cc9 100644
--- a/doc/src/sgml/release-11.sgml
+++ b/doc/src/sgml/release-11.sgml
@@ -196,10 +196,6 @@
         would be dumped without such specifications if the database locale
         and encoding matched the old cluster's defaults.
        </para>
-
-       <para>
-        DID I GET EVERYTHING?
-       </para>
       </listitem>
 
       <listitem>
@@ -614,8 +610,7 @@
         The new command <link linkend="sql-alterindex"><command>ALTER
         INDEX ATTACH PARTITION</command></link> allows indexes to be
         attached to partitions.  This does not behave as a global index
-        since the contents are private to each index.  WARN WHEN USING
-        AN EXISTING INDEX?
+        since the contents are private to each index.
        </para>
       </listitem>
 
@@ -924,7 +919,7 @@ same commits as above
        </para>
 
        <para>
-        This reduces the likelihood of serialization conflicts.  ACCURATE?
+        This reduces the likelihood of serialization conflicts.
        </para>
       </listitem>
 
@@ -1997,7 +1992,6 @@ same commits as above
         <command>CALL</command>s or in nested PL/pgSQL DO and
         <command>CALL</command> blocks that only contain other PL/pgSQL
         <command>DO</command> and <command>CALL</command> blocks.
-        ACCURATE?
        </para>
       </listitem>
 
@@ -2422,11 +2416,6 @@ same commits as above
         when the <acronym>WAL</acronym> streaming method
         (<option>--wal-method=stream</option>) is used.
        </para>
-
-       <para>
-        IS IT CLEAR FROM THE DOCS THAT THE REPLICATION SLOT IS NOT
-        TEMPORARY?
-       </para>
       </listitem>
 
       <listitem>
@@ -2921,7 +2910,8 @@ same commits as above
        </para>
 
        <para>
-        This is useful for KNN-GiST searches.  HOW?
+        This is useful for KNN-GiST searches when looking for coordinates in
+        descending order.
        </para>
       </listitem>
 
-- 
2.14.3 (Apple Git-98)



  signature.asc (application/pgp-signature, 832B) download