From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: Christoph Berg <myon@debian.org>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Log LDAP "diagnostic messages"?
Date: Thu, 14 Sep 2017 16:12:05 +0200
Message-ID: <20170914141205.eup4kxzlkagtmfac@alvherre.pgsql> (raw)
In-Reply-To: <CAEepm=0+yacrtrRrKnsMHiRNTkXM=uLAHX47=LHx7FWy_bn4Zw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
I think the ldap_unbind() changes should be in a separate preliminary
patch to be committed separately and backpatched.
The other bits looks fine, with nitpicks
1. please move the new support function to the bottom of the section
dedicated to LDAP, and include a prototype
2. please wrap lines longer than 80 chars, other than error message
strings. (I don't know why this file plays fast & loose with
project-wide line length rules, but I also see no reason to continue
doing it.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, thomas.munro@enterprisedb.com, ashutosh.bapat@enterprisedb.com, myon@debian.org
Subject: Re: Log LDAP "diagnostic messages"?
In-Reply-To: <20170914141205.eup4kxzlkagtmfac@alvherre.pgsql>
References: <CAEepm=0+yacrtrRrKnsMHiRNTkXM=uLAHX47=LHx7FWy_bn4Zw@mail.gmail.com> <20170914141205.eup4kxzlkagtmfac@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox