From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Ashutosh Bapat <ashutosh.bapat@gmail.com>
Subject: Re: print_path is missing GatherMerge and CustomScan support
Date: Wed, 18 Jul 2018 15:22:02 +0900
Message-ID: <20180718062202.GC8565@paquier.xyz> (raw)
In-Reply-To: <CAD21AoBQMLoc=ohH-oocuAPsELrmk8_EsRJjOyR8FQLZkbE0wA@mail.gmail.com>
References: <CAD21AoBQMLoc=ohH-oocuAPsELrmk8_EsRJjOyR8FQLZkbE0wA@mail.gmail.com>
On Wed, Jul 18, 2018 at 02:35:23PM +0900, Masahiko Sawada wrote:
> Hi,
>
> While debugging planner I realized that print_path() function is not
> aware of both GatherMerge path and CustomScan path. Attached small
> patch fixes it.
Good catch. Those should be backpatched. While I am looking at this
stuff, I have noticed that pathnode.c/reparameterize_path_by_child uses
T_MergeAppend and not T_MergeAppendPath.
inline patch 1: src/backend/optimizer/util/pathnode.c (+1/-1 lines) download inline-1.patch--- a/src/backend/optimizer/util/pathnode.c+++ b/src/backend/optimizer/util/pathnode.c@@ -3817,7 +3817,7 @@ do { \
}
break;
- case T_MergeAppend:+ case T_MergeAppendPath:
{
MergeAppendPath *mapath
This is new as of f49842d1 in v11. Robert, Ashutosh, am I missing
something?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, sawada.mshk@gmail.com, robertmhaas@gmail.com, ashutosh.bapat@gmail.com
Subject: Re: print_path is missing GatherMerge and CustomScan support
In-Reply-To: <20180718062202.GC8565@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox