pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Remove absolete function TupleDescGetSlot().
Date: Wed, 26 Sep 2018 09:04:14 +0900
Message-ID: <20180926000413.GC1659@paquier.xyz> (raw)
In-Reply-To: <E1g4wv3-0001Q0-8n@gemulon.postgresql.org>
References: <E1g4wv3-0001Q0-8n@gemulon.postgresql.org>

Hi Andres,

On Tue, Sep 25, 2018 at 11:39:05PM +0000, Andres Freund wrote:
> Remove absolete function TupleDescGetSlot().
> 
> TupleDescGetSlot() was kept around for backward compatibility for
> user-written SRFs. With the TupleTableSlot abstraction work, that code
> will need to be version specific anyway, so there's no point in
> keeping the function around any longer.

There are still references in the code to this function, and a
declaration of it:
git grep TupleDescGetSlot
doc/src/sgml/xfunc.sgml:     * user-defined SRFs that use the deprecated TupleDescGetSlot().
src/include/funcapi.h:   * user-defined SRFs that use the deprecated TupleDescGetSlot().
src/include/funcapi.h: * TupleTableSlot *TupleDescGetSlot(TupleDesc tupdesc) - Builds a
src/include/funcapi.h:extern TupleTableSlot *TupleDescGetSlot(TupleDesc tupdesc);
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (8+ messages)  latest in thread

Message-ID: <20180926000413.GC1659@paquier.xyz>
Permalink:  ../20180926000413.GC1659@paquier.xyz/
Also on:    postgresql.org/message-id/20180926000413.GC1659@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, andres@anarazel.de, pgsql-hackers@postgresql.org
  Subject: Re: pgsql: Remove absolete function TupleDescGetSlot().
  In-Reply-To: <20180926000413.GC1659@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox