[Stephen Frost <sfrost@snowman.net>]

Greetings,

* Michael Paquier (michael.paquier@gmail.com) wrote:
> On Fri, May 26, 2017 at 8:14 AM, Daniel Gustafsson <daniel@yesql.se> wrote:
> >> On 26 May 2017, at 17:08, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> I'll commit and back-patch this without a test case.  Possibly Frost will
> >> be excited enough about it to add something to the pg_dump TAP tests,
> >> but those tests are too opaque for me to want to do so.
> 
> For the TAP tests I think that you are looking for something like the
> attached. Stephen, perhaps you could consider including this test in
> the suite?

Another blast from the past.  I've updated this to the new pg_dump
test-suite system but otherwise it's basically the same test.

Barring concerns, I'll plan to push this later this weekend.

Thanks!

Stephen

Attachments:

add-empty-op-class-pg_dump-test-v1_master.patch (text/x-diff, 1.0K) download
diff --git a/src/bin/pg_dump/t/002_pg_dump.pl b/src/bin/pg_dump/t/002_pg_dump.pl
new file mode 100644
index 2afd950..c687f0f
*** a/src/bin/pg_dump/t/002_pg_dump.pl
--- b/src/bin/pg_dump/t/002_pg_dump.pl
*************** my %tests = (
*** 1521,1526 ****
--- 1521,1541 ----
  		unlike => { exclude_dump_test_schema => 1, },
  	},
  
+ 	'CREATE OPERATOR CLASS dump_test.op_class_empty' => {
+ 		create_order => 89,
+ 		create_sql   => 'CREATE OPERATOR CLASS dump_test.op_class_empty
+ 		                 FOR TYPE bigint USING btree FAMILY dump_test.op_family
+ 						 AS STORAGE bigint;',
+ 		regexp => qr/^
+ 			\QCREATE OPERATOR CLASS dump_test.op_class_empty\E\n\s+
+ 			\QFOR TYPE bigint USING btree FAMILY dump_test.op_family AS\E\n\s+
+ 			\QSTORAGE bigint;\E
+ 			/xm,
+ 		like =>
+ 		  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
+ 		unlike => { exclude_dump_test_schema => 1, },
+ 	},
+ 
  	'CREATE EVENT TRIGGER test_event_trigger' => {
  		create_order => 33,
  		create_sql   => 'CREATE EVENT TRIGGER test_event_trigger

  signature.asc (application/pgp-signature, 818B) download