From: Michael Paquier <michael@paquier.xyz>
To: Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS
Date: Wed, 19 Dec 2018 18:22:55 +0900
Message-ID: <20181219092255.GC680@paquier.xyz> (raw)
In-Reply-To: <830f4ef8-577e-53ed-4017-adad9c21d2e2@lab.ntt.co.jp>
References: <d677594b-101a-6236-7774-94a7c1a7b56b@lab.ntt.co.jp>
<20181128.131428.84607836.horiguchi.kyotaro@lab.ntt.co.jp>
<54bd214b-d0d3-8654-e71f-45e7b4f979f0@lab.ntt.co.jp>
<20181130.154654.56222303.horiguchi.kyotaro@lab.ntt.co.jp>
<a1812926-5452-712f-07b0-e347a8a33aca@lab.ntt.co.jp>
<20181219052705.GD19856@paquier.xyz>
<830f4ef8-577e-53ed-4017-adad9c21d2e2@lab.ntt.co.jp>
On Wed, Dec 19, 2018 at 04:26:27PM +0900, Tatsuro Yamada wrote:
> Yep, I already did that for ALTER INDEX in tab_completion_alter_index_set_statistics.patch like this:
>
> + /* ALTER INDEX <name> ALTER COLUMN <colname> SET STATISTICS */
> + else if (HeadMatches("ALTER", "INDEX") && TailMatches("SET", "STATISTICS")){
> + /* We don't complete after "SET STATISTICS" */
> + }
[Wake up, Neo]
Okay, then I propose to first extract a patch which does the following
things as a first step to simplify the follow-up work:
- No completion after "ALTER TABLE/INDEX SET STATISTICS" instead of
schemas.
- Complete "ALTER INDEX foo ALTER COLUMN SET" with STATISTICS (now this
prints parameters, which is annoying).
Then let's figure out the details for the rest.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20181219092255.GC680@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, yamada.tatsuro@lab.ntt.co.jp, horiguchi.kyotaro@lab.ntt.co.jp, pgsql-hackers@lists.postgresql.org
Subject: Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS
In-Reply-To: <20181219092255.GC680@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox