pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: pg12 release notes
Date: Thu, 9 May 2019 20:34:49 -0500
Message-ID: <20190510013449.GL3925@telsasoft.com> (raw)
In-Reply-To: <20190510010251.ppjlkn32okaokynn@momjian.us>
References: <20190508203204.GA25482@telsasoft.com>
	<20190509233518.gqaelz5zao4jcznx@momjian.us>
	<20190510001335.GJ3925@telsasoft.com>
	<20190510010251.ppjlkn32okaokynn@momjian.us>

On Thu, May 09, 2019 at 09:02:51PM -0400, Bruce Momjian wrote:
> These were all very helpful.  I adjusted your changes to create the
> attached applied patch.  URL updated:

Thanks.

> -Allow more comparisons with information_schema text columns to use indexes (Tom Lane)
> +Allow more use of indexes for text columns comparisons with information_schema columns (Tom Lane)

I think "columns" should not be plural..but it could be better still:

|Allow use of indexes for more comparisons with text columns of information_schema (Tom Lane)

Regarding this proposed change of mine:
-Btree indexes pg_upgraded from previous releases will not have this ordering.  This slightly reduces the maximum length of indexed values.
+Btree indexes pg_upgraded from previous releases will not have this ordering.  This slightly reduces the maximum permitted length of indexed values.

I think "permitted" is important, since otherwise it sounds like maybe for
whatever values are being indexed, their maximum length is reduced by this
patch.  If you overthink it, you could decide that maybe that's happening due
to use of prefix/suffix truncation or something ..

Should this one be listed twice ?  I tried to tell if it was intentional but
couldn't decide..
249d64999 Add support TCP user timeout in libpq and the backend se

Justin





view thread (41+ messages)  latest in thread

Message-ID: <20190510013449.GL3925@telsasoft.com>
Permalink:  ../20190510013449.GL3925@telsasoft.com/
Also on:    postgresql.org/message-id/20190510013449.GL3925@telsasoft.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, bruce@momjian.us
  Subject: Re: pg12 release notes
  In-Reply-To: <20190510013449.GL3925@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox