From: Tom Lane <tgl@sss.pgh.pa.us>
To: Raúl Marín Rodríguez <rmrodriguez@carto.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
Date: Sun, 20 Jan 2019 20:51:01 -0500
Message-ID: <20202.1548035461@sss.pgh.pa.us> (raw)
In-Reply-To: <CAM6_UM7fi-v5e90ghaZCLEfU4_Tk0n9=M6no5f1eXnMeLSeN0g@mail.gmail.com>
References: <201901181927.sbv5o72uu4cc@alvherre.pgsql>
<29026.1547841766@sss.pgh.pa.us>
<32650.1547843169@sss.pgh.pa.us>
<CAM6_UM7fi-v5e90ghaZCLEfU4_Tk0n9=M6no5f1eXnMeLSeN0g@mail.gmail.com>
=?UTF-8?B?UmHDumwgTWFyw61uIFJvZHLDrWd1ZXo=?= <rmrodriguez@carto.com> writes:
>> Pushed with that correction.
> Thanks a lot!
Hm, so bowerbird (a Windows machine) has been failing the pgbench tests
since this went in, cf
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2019-01-20%2004%3A57%3A01
I'm just guessing, but I suspect that bowerbird is using a path spec that
includes a backslash directory separator and that's somehow bollixing
things. If so, we might be able to fix it by converting backslashes to
forward slashes before applying quotemeta().
It's also possible that on Windows, "glob" handles backslashes
differently than it does elsewhere, which would be harder to fix
--- that would bring back my original fear that the appropriate
quoting rules are different for "glob" than for regexes.
Andrew, any insight?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, rmrodriguez@carto.com, andrew@dunslane.net, alvherre@2ndquadrant.com
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
In-Reply-To: <20202.1548035461@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox