pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: pg14 psql broke \d datname.nspname.relname
Date: Wed, 13 Oct 2021 11:54:26 -0500
Message-ID: <20211013165426.GD27491@telsasoft.com> (raw)
In-Reply-To: <CA+TgmoaH+nHJj1Y7poj2mE8Pa88qF_36QtXh5Mej_4ZJU=0fJg@mail.gmail.com>
References: <22E8AB10-FEB4-40BB-8CAF-16AC9EBA15A3@enterprisedb.com>
	<529470.1633996189@sss.pgh.pa.us>
	<A76B6CAA-B740-4979-BB61-97E5B31334E4@enterprisedb.com>
	<CAH2-Wz=S9OL4nwppApn2F4HVQDDUjzow8HhZfCMU3+Uyt-u7mA@mail.gmail.com>
	<CA+Tgmoa6KR0nZAxQxEZRyemaEBWPJuASc7ebxEZePi-TS4mMsw@mail.gmail.com>
	<573388.1634049057@sss.pgh.pa.us>
	<CA+TgmobAotQ-dKgdDmVE+8ZuiOfcfnppVqXm36+QxUQi4dJNCA@mail.gmail.com>
	<20211012151955.GI20998@tamriel.snowman.net>
	<20211012165745.GM27491@telsasoft.com>
	<CA+TgmoaH+nHJj1Y7poj2mE8Pa88qF_36QtXh5Mej_4ZJU=0fJg@mail.gmail.com>

On Wed, Oct 13, 2021 at 12:46:27PM -0400, Robert Haas wrote:
> On Tue, Oct 12, 2021 at 12:57 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> > I would prefer if it errored if the datname didn't match the current database.
> > After all, it would've helped me to avoid making a confusing problem report.
> 
> How would you have felt if it had said something like:
> 
> error: argument to \d should be of the form
> [schema-name-pattern.]relation-name-pattern
> 
> Would that have been better or worse for you than accepting a third
> part of the pattern as a database name if and only if it matched the
> current database name exactly?

I don't normally type \d a.b.c.  I think I copied it out of a log message and
pasted it, and didn't even really know or expect it to work without removing
the datname prefix.  After it worked, I noticed a short while later when using
the pg14 client that it had stopped working.

It seems unfortunate if names from log messages qualified with datname were now
rejected.  Like this one:

| automatic analyze of table "ts.child.cdrs_2021_10_12"...

-- 
Justin





view thread (80+ messages)  latest in thread

Message-ID: <20211013165426.GD27491@telsasoft.com>
Permalink:  ../20211013165426.GD27491@telsasoft.com/
Also on:    postgresql.org/message-id/20211013165426.GD27491@telsasoft.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, robertmhaas@gmail.com, sfrost@snowman.net, tgl@sss.pgh.pa.us, pg@bowt.ie, mark.dilger@enterprisedb.com
  Subject: Re: pg14 psql broke \d datname.nspname.relname
  In-Reply-To: <20211013165426.GD27491@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox