From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
Date: Tue, 16 Nov 2021 14:09:36 -0300
Message-ID: <202111161709.u3pbx5lxdimt@alvherre.pgsql> (raw)
In-Reply-To: <E1mn1OI-0007WG-H9@gemulon.postgresql.org>
On 2021-Nov-16, Alvaro Herrera wrote:
> Fix headerscheck failure in replication/worker_internal.h
The other failure is in src/include/libpq/be-gssapi-common.h:
In file included from /tmp/headerscheck.a6f0um/test.c:2:
./src/include/libpq/be-gssapi-common.h:20:10: fatal error: gssapi/gssapi.h: No existe el fichero o el directorio
20 | #include <gssapi/gssapi.h>
| ^~~~~~~~~~~~~~~~~
compilation terminated.
One possible solution for this one is to add an exclusion in
headerscheck (and cpluspluscheck?); the other possible solution seems to
be to wrap the whole contents of the file in "#ifdef ENABLE_GSS". I
think the latter is roughly the approach used for OpenSSL inclusions.
--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
In-Reply-To: <202111161709.u3pbx5lxdimt@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox